Skip to content

[envpool] Fix flexible lint toolchain drift - #329

Merged
Trinkle23897 merged 3 commits into
mainfrom
jiayi/cpplint-2-compat
Mar 20, 2026
Merged

[envpool] Fix flexible lint toolchain drift#329
Trinkle23897 merged 3 commits into
mainfrom
jiayi/cpplint-2-compat

Conversation

@Trinkle23897

@Trinkle23897 Trinkle23897 commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • fix the latest flexible lint drift surfaced by current tool versions instead of pinning older tooling
  • make Bazel BUILD files compatible with current buildifier
  • make addlicense, mypy, docstyle, and spelling pass again under current environments

Technical Details

  • add explicit rules_python / rules_cc loads so current buildifier no longer flags legacy native rule usage
  • add Apache headers to the affected third-party BUILD stubs and switch the generated header year to 2026
  • tighten Python typing in the envpool adapters/tests so current mypy passes without pinning the checker
  • remove the deprecated Sphinx theme-path usage and make the docs install path self-contained in clean environments by ensuring doc8, setuptools, and pbr are present
  • make make spelling install libenchant-2-dev automatically on Linux when the enchant C library is missing
  • extend the docs spelling wordlist for the formatter names used in the contribution guide

Test Plan

  • local: make buildifier
  • local: make addlicense
  • local: make py-format
  • local: make flake8
  • local: make mypy
  • local: make docstyle
  • dev-0: make buildifier
  • dev-0: make addlicense
  • dev-0: make py-format
  • dev-0: make flake8
  • dev-0: make mypy
  • dev-0: make docstyle
  • dev-0: make doc-clean && make spelling
  • dev-0: make spelling

@Trinkle23897 Trinkle23897 changed the title [envpool] Make cpplint 2.0.2-compatible [envpool] Fix flexible lint toolchain drift Mar 20, 2026
@Trinkle23897
Trinkle23897 merged commit ec52961 into main Mar 20, 2026
2 of 4 checks passed
@Trinkle23897
Trinkle23897 deleted the jiayi/cpplint-2-compat branch March 20, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant