-
Notifications
You must be signed in to change notification settings - Fork 141
[envpool] Fix Linux test workflow compatibility #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 6.0.0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,15 +18,24 @@ load("@com_github_nelhage_rules_boost//:boost/boost.bzl", "boost_deps") | |
| load("@com_justbuchanan_rules_qt//:qt_configure.bzl", "qt_configure") | ||
| load("@pybind11_bazel//:python_configure.bzl", "python_configure") | ||
| load("@rules_foreign_cc//foreign_cc:repositories.bzl", "rules_foreign_cc_dependencies") | ||
| load("@rules_python//python:repositories.bzl", "python_register_toolchains") | ||
|
|
||
| def workspace(): | ||
| """Configure pip requirements.""" | ||
| python_register_toolchains( | ||
| name = "python3_10", | ||
| python_version = "3.10", | ||
| ignore_root_user_error = True, | ||
| ) | ||
|
|
||
| python_configure( | ||
| name = "local_config_python", | ||
| python_version = "3", | ||
| python_interpreter_target = "@python3_10_x86_64-unknown-linux-gnu//:bin/python3", | ||
|
Comment on lines
31
to
+33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Hard-coding Useful? React with 👍 / 👎. |
||
| ) | ||
|
|
||
| rules_foreign_cc_dependencies() | ||
| rules_foreign_cc_dependencies( | ||
| register_built_pkgconfig_toolchain = False, | ||
| ) | ||
|
|
||
| boost_deps() | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| setuptools | ||
| wheel | ||
| numpy | ||
| numpy<2 | ||
| dm-env | ||
| gym>=0.26 | ||
| gymnasium>=0.26,!=0.27.0 | ||
| optree>=0.6.0 | ||
| jax[cpu] | ||
| jax[cpu]<0.5 | ||
| packaging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching all
RuntimeErrors here turns these into false-negative tests.env.xla()already has unrelated runtime-error paths inenvpool/core/py_envpool.h:220-232, so if Atari XLA starts failing for any reason other than the specific legacy-JAX API removal, CI will now report this as a skipped test instead of a regression. Restrict the skip to the explicit compatibility error message so supported JAX builds still fail when XLA itself breaks.Useful? React with 👍 / 👎.