Skip to content

[envpool] upgrade direct dependencies and remove stale mirrors - #334

Merged
Trinkle23897 merged 9 commits into
mainfrom
jiayi/envpool-direct-dep-upgrades
Mar 21, 2026
Merged

[envpool] upgrade direct dependencies and remove stale mirrors#334
Trinkle23897 merged 9 commits into
mainfrom
jiayi/envpool-direct-dep-upgrades

Conversation

@Trinkle23897

Copy link
Copy Markdown
Collaborator

Summary

  • Problem: EnvPool still pinned several direct Python and native dependencies to old versions, and WORKSPACE still referenced the retired https://ml.cs.tsinghua.edu.cn/~jiayi/envpool mirror.
  • Scope: keep the retained first-round upgrades only: MuJoCo / dm_control versions, Python requirement floors and lockfiles, selected direct native archive versions (pybind11, glog, googletest, zlib), and matching docs / build-file updates. This PR intentionally excludes the experimental second-round Bazel / toolchain / broader C++ dependency bumps.
  • Outcome: the retained direct dependency set is newer and consistent across Bazel archives, Python lockfiles, MuJoCo build outputs, and docs, and the stale mirror URLs are removed.

This narrows the dependency refresh to the direct changes that are easiest to review and keep, while dropping the more invasive toolchain work.

Technical Details

  • Approach: update the direct dependency versions in workspace0.bzl and pip requirement files, regenerate the Linux lockfiles, and sync MuJoCo shared-library names plus doc references to the retained versions.
  • Code pointers:
    • envpool/workspace0.bzl: removes the stale mirror URLs and bumps the retained native archive versions.
    • third_party/pip_requirements/requirements-dev.txt: updates the dev/runtime dependency inputs that feed the lockfiles.
    • envpool/mujoco/BUILD: updates the generated MuJoCo shared library output to match 3.6.0.
  • Notes: I temporarily explored a second round of Bazel / toolchain / C++ dependency upgrades during debugging, but rolled those changes back before publishing this PR.

Test Plan

Automated

  • brix ssh dev-0 -C -- '<targeted bazel test run on the retained first-round dependency set>': earlier targeted dev validation passed the core buffer tests plus MuJoCo / dm_control alignment tests for the retained dependency-refresh path.

Suggested Manual

  • brix ssh dev-0 -C -- 'cd /root/code/envpool && bazel test //envpool/mujoco:mujoco_gym_deterministic_test //envpool/mujoco:mujoco_gym_align_test //envpool/mujoco:mujoco_dmc_suite_deterministic_test //envpool/mujoco:mujoco_dmc_suite_align_test --test_output=errors': revalidate the final PR branch on Linux.
  • rg -n "ml\\.cs\\.tsinghua\\.edu\\.cn/~jiayi/envpool" envpool/workspace0.bzl: confirm the retired mirror URL is gone.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff4dcb14bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread benchmark/requirements.txt
@Trinkle23897
Trinkle23897 merged commit 4180328 into main Mar 21, 2026
2 of 4 checks passed
@Trinkle23897
Trinkle23897 deleted the jiayi/envpool-direct-dep-upgrades branch March 21, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant