[envpool] upgrade direct dependencies and remove stale mirrors - #334
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff4dcb14bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WORKSPACEstill referenced the retiredhttps://ml.cs.tsinghua.edu.cn/~jiayi/envpoolmirror.pybind11,glog,googletest,zlib), and matching docs / build-file updates. This PR intentionally excludes the experimental second-round Bazel / toolchain / broader C++ dependency bumps.This narrows the dependency refresh to the direct changes that are easiest to review and keep, while dropping the more invasive toolchain work.
Technical Details
workspace0.bzland pip requirement files, regenerate the Linux lockfiles, and sync MuJoCo shared-library names plus doc references to the retained versions.envpool/workspace0.bzl: removes the stale mirror URLs and bumps the retained native archive versions.third_party/pip_requirements/requirements-dev.txt: updates the dev/runtime dependency inputs that feed the lockfiles.envpool/mujoco/BUILD: updates the generated MuJoCo shared library output to match 3.6.0.Test Plan
Automated
brix ssh dev-0 -C -- '<targeted bazel test run on the retained first-round dependency set>': earlier targeted dev validation passed the core buffer tests plus MuJoCo / dm_control alignment tests for the retained dependency-refresh path.Suggested Manual
brix ssh dev-0 -C -- 'cd /root/code/envpool && bazel test //envpool/mujoco:mujoco_gym_deterministic_test //envpool/mujoco:mujoco_gym_align_test //envpool/mujoco:mujoco_dmc_suite_deterministic_test //envpool/mujoco:mujoco_dmc_suite_align_test --test_output=errors': revalidate the final PR branch on Linux.rg -n "ml\\.cs\\.tsinghua\\.edu\\.cn/~jiayi/envpool" envpool/workspace0.bzl: confirm the retired mirror URL is gone.