IDE-16 Use correct contextual help#148
Open
etaishev wants to merge 1 commit intosailfishos:masterfrom
Open
Conversation
Member
|
This touches just upstream code. Could you please get this accepted by upstream first? |
Contributor
Author
|
Ok. Now has some tasks in upstream which fix similar problems with help, but Qt Gerrit Reviews unavailable. I'll wait for them first. |
Elements with same name (for example Sailfish.Silica.Button and QtQuick.Controls.Button) have a same helpId and QtCreator help plugin first of all select Qt link. This patch resolve the issue by looking for a module name of element and select best, then return url as helpId.
etaishev
force-pushed
the
IDE-16-Use-correct-contextual-help
branch
from
7c86412 to
ae8f92d
Compare
Contributor
Author
|
Well in last QtCreator this bug didn't fixed. The same as our bug was closed and marked as duplicate(QTCREATORBUG-17657). But the QTCREATORBUG-18527 isn't same and fix of it don't work for us. My fix unlikely get accepted to upstream |
Member
|
Open your own upstream bug then? Submitting your patch for review ideally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elements with same name (for example Sailfish.Silica.Button and QtQuick.Controls.Button) have a same helpId and
QtCreator help plugin first of all select Qt link.
This patch resolve the issue by looking for a module name of element and select best, then return url as helpId.