move the tile of the "Calculate PEC on packets" from the left side of… - #5
Merged
Conversation
… the check box to the right side of the checkbox. TODO: what is the impact to the API for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves the title of the "Calculate PEC on packets" checkbox over to the right side of the checkbox, called the "Checkbox Text"
Before
After
Note, this should not affect the Logic 2 automation API interface for this analyzer, because the add analyzer functionality will match settings keys based first on setting title, but if the setting title is blank, and the setting is a checkbox, it fall back to the checkbox text.