-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Improve table design consistency across the dashboard #6276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
ad59835
Unify ResponsiveTable design; Fix visual consistency of Shipping Methods
mirekm 89f45bf
WIP
mirekm 1824e08
Updating ReactiveTable across the entire Dashboard
mirekm 6103855
Improve the ResponsiveTable styling; Stick variants list
mirekm d8e5e90
Improve variants page
mirekm 0459dfa
Unify the loading phases pattern for all ResponsiveTables
mirekm c839086
Mock scrollIntoView in test fixture
mirekm 863fdc9
Add changeset
mirekm c9503b4
Extract messages
mirekm 3913f81
Remove old dead part of the code
mirekm acc3bc5
Merge branch 'main' into fix/responsive-table-design
mirekm 0280cf5
Merge branch 'main' into fix/responsive-table-design
mirekm fdb11c1
Fix error button
mirekm 7cc7165
Revert mistakenly overritten changelog entry
mirekm 05ece6d
Add changeset
mirekm 1bf7277
Trim AGENTS.MD to the minimum
mirekm 114a479
Handle plural
mirekm 26a281a
Remove unused styles
mirekm e238d52
Drop barrel index
mirekm a4c9f5f
Refactor
mirekm c0009c7
Merge branch 'main' into fix/responsive-table-design
mirekm 03bc327
Apply suggestions from code review
witoszekdev 8101631
Update messages
witoszekdev e47909f
fix messages, add plural
witoszekdev 316db9c
apply other review comments
witoszekdev 4974de7
Merge branch 'main' into fix/responsive-table-design
witoszekdev 05fd85e
fix incorreclty added changeset
witoszekdev a950d14
Merge branch 'main' into fix/responsive-table-design
mirekm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "saleor-dashboard": patch | ||
| --- | ||
|
|
||
| Improve table design consistency across the dashboard with unified styling for ResponsiveTable components, better loading states, and improved scroll behavior for variant navigation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: maybe in general we should migrate to skills for specific tasks like this one (writing / refactoring components that display list) - I think it works better in general: agents.md tends to get ignored + we pollute our context less.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - 100%. I internally use both rules and skills. Just had no time to pull it together yet as I initially did for our storefront on the Paper PR/branch.