-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Improve table design consistency across the dashboard #6276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 11 commits
ad59835
89f45bf
1824e08
6103855
d8e5e90
0459dfa
c839086
863fdc9
c9503b4
3913f81
acc3bc5
0280cf5
fdb11c1
7cc7165
05ece6d
1bf7277
114a479
26a281a
e238d52
a4c9f5f
c0009c7
03bc327
8101631
e47909f
316db9c
4974de7
05fd85e
a950d14
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -127,6 +127,21 @@ The codebase follows a feature-based architecture with shared components: | |
| - Implement proper form validation with React Hook Form | ||
| - Add internationalization support for user-facing text | ||
|
|
||
| ### UI Design Guidelines | ||
|
|
||
| **Before redesigning any component that displays a list, ask: "What happens with 50+ items?"** | ||
|
|
||
| If the list could be long: | ||
|
|
||
| - Add scrollable container with `max-height` | ||
| - Keep headers outside the scroll area | ||
| - Auto-scroll to active item on load | ||
|
|
||
| Other considerations: | ||
|
|
||
| - Loading states: Show skeletons | ||
| - Empty states: Handle zero items gracefully | ||
|
Comment on lines
+130
to
+143
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: maybe in general we should migrate to skills for specific tasks like this one (writing / refactoring components that display list) - I think it works better in general: agents.md tends to get ignored + we pollute our context less.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes - 100%. I internally use both rules and skills. Just had no time to pull it together yet as I initially did for our storefront on the Paper PR/branch. |
||
|
|
||
| ### Testing Requirements | ||
|
|
||
| - Write unit tests for utility functions and complex components | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.