Skip to content

feat(warehouse): Add metadata edition modal - #6284

Merged
witoszekdev merged 6 commits into
saleor:mainfrom
xseignard:main
Jan 29, 2026
Merged

feat(warehouse): Add metadata edition modal#6284
witoszekdev merged 6 commits into
saleor:mainfrom
xseignard:main

Conversation

@xseignard

@xseignard xseignard commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Scope of the change

Adds metadata editing capability to warehouse pages, following the same pattern as order metadata editing.

Changes:

  • Added metadata and privateMetadata fields to the WarehouseDetails GraphQL fragment
  • Created WarehouseMetadataDialog component using the shared MetadataDialog
  • Added metadata button (Code icon) to the warehouse details page TopNav
  • Added ripple indicator to highlight the new feature
  • Updated warehouse fixtures with metadata fields
Enregistrement.de.l.ecran.2026-01-27.a.19.07.32.mov
Capture d’écran 2026-01-27 à 19 42 07 Capture d’écran 2026-01-27 à 19 42 23
  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

@xseignard
xseignard requested a review from a team as a code owner January 27, 2026 18:41
@changeset-bot

changeset-bot Bot commented Jan 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2554485

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Jan 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.50%. Comparing base (6f61b4f) to head (2554485).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...arehouseMetadataDialog/WarehouseMetadataDialog.tsx 80.95% 3 Missing and 1 partial ⚠️
...houses/views/WarehouseDetails/WarehouseDetails.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6284      +/-   ##
==========================================
+ Coverage   42.48%   42.50%   +0.02%     
==========================================
  Files        2492     2494       +2     
  Lines       43235    43259      +24     
  Branches     9791    10181     +390     
==========================================
+ Hits        18369    18389      +20     
+ Misses      24830    23547    -1283     
- Partials       36     1323    +1287     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xseignard

Copy link
Copy Markdown
Contributor Author

I think adding a label skip macaw migration check will be needed on this one

@mirekm

mirekm commented Jan 28, 2026

Copy link
Copy Markdown
Member

Great! We need more of that pattern across the entire Dashboard but especially in places where metadata was missing. Thanks and let us look through this in the coming days.

@witoszekdev witoszekdev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@witoszekdev
witoszekdev merged commit 1a8279b into saleor:main Jan 29, 2026
11 of 12 checks passed
@witoszekdev

Copy link
Copy Markdown
Contributor

Thanks @xseignard for contribution and for documenting everything with recordings 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants