Skip to content

Fix broken pagination in response for simple product creation - #6305

Merged
witoszekdev merged 2 commits into
mainfrom
fix/hasvariants-false-product-create
Feb 2, 2026
Merged

Fix broken pagination in response for simple product creation#6305
witoszekdev merged 2 commits into
mainfrom
fix/hasvariants-false-product-create

Conversation

@mirekm

@mirekm mirekm commented Jan 30, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings January 30, 2026 18:51
@mirekm
mirekm requested a review from a team as a code owner January 30, 2026 18:51
@changeset-bot

changeset-bot Bot commented Jan 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: af9d35c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where pagination parameters were missing when creating simple product variants, which would cause incomplete data to be returned for attribute choices.

Changes:

  • Added firstValues: VALUES_PAGINATE_BY parameter to the variant creation mutation variables for simple products
  • Imported VALUES_PAGINATE_BY constant from config

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jan 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.58%. Comparing base (5b88aac) to head (af9d35c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #6305     +/-   ##
=========================================
  Coverage   42.58%   42.58%             
=========================================
  Files        2497     2497             
  Lines       43376    43376             
  Branches    10250    10233     -17     
=========================================
  Hits        18470    18470             
- Misses      23581    24869   +1288     
+ Partials     1325       37   -1288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@witoszekdev
witoszekdev merged commit b53b0d7 into main Feb 2, 2026
14 checks passed
@witoszekdev
witoszekdev deleted the fix/hasvariants-false-product-create branch February 2, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants