Skip to content

Fixed bug where extensions() query was executed multiple times - #6447

Merged
lkostrowski merged 3 commits into
mainfrom
lkostrowski/fix-extension-list-refetch
Mar 23, 2026
Merged

Fixed bug where extensions() query was executed multiple times #6447
lkostrowski merged 3 commits into
mainfrom
lkostrowski/fix-extension-list-refetch

Conversation

@lkostrowski

Copy link
Copy Markdown
Member

No description provided.

@lkostrowski
lkostrowski requested a review from a team as a code owner March 20, 2026 12:26
@changeset-bot

changeset-bot Bot commented Mar 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0a0665f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Fixed bug where extensions() query was executed multiple times

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes per-menu-item extension lookup/opening logic from the sidebar’s SingleItem component, addressing the reported issue where the extensions() query was being triggered multiple times due to repeated extension hook usage.

Changes:

  • Removed useExtensions(...) usage from SingleItem to avoid per-item extension fetching.
  • Removed getMenuItemExtension(...)-based click handling and now relies on menuItem.onClick when present.

@codecov

codecov Bot commented Mar 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.58%. Comparing base (60b7b17) to head (0a0665f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6447    +/-   ##
========================================
  Coverage   43.58%   43.58%            
========================================
  Files        2585     2585            
  Lines       44991    44985     -6     
  Branches    10148    10541   +393     
========================================
- Hits        19609    19607     -2     
+ Misses      25342    25338     -4     
  Partials       40       40            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkostrowski
lkostrowski merged commit f5c2172 into main Mar 23, 2026
15 of 17 checks passed
@lkostrowski
lkostrowski deleted the lkostrowski/fix-extension-list-refetch branch March 23, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants