Skip to content

feat: remove gift card code export - #6875

Merged
lkostrowski merged 2 commits into
mainfrom
lkostrowski/staging-schema-attribute-fields-v1
Aug 26, 2026
Merged

feat: remove gift card code export#6875
lkostrowski merged 2 commits into
mainfrom
lkostrowski/staging-schema-attribute-fields-v1

Conversation

@lkostrowski

Copy link
Copy Markdown
Member

exportGiftCards is gone from the 3.24 API and deprecated on 3.23, where it stays reachable directly through the API. Rather than keep the UI alive behind a schema check, the export dialog and its entry points are removed.

The bulk-issue success dialog goes with them — offering to email the codes was its only action, so the success notification is now the only confirmation.

Scope of the change

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

`exportGiftCards` is gone from the 3.24 API and deprecated on 3.23, where it
stays reachable directly through the API. Rather than keep the UI alive behind
a schema check, the export dialog and its entry points are removed.

The bulk-issue success dialog goes with them — offering to email the codes was
its only action, so the success notification is now the only confirmation.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@lkostrowski
lkostrowski requested review from a team and wcislo-saleor August 26, 2026 16:39
@changeset-bot

changeset-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5dc5449

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lkostrowski
lkostrowski requested a review from mirekm August 26, 2026 16:39
@lkostrowski
lkostrowski enabled auto-merge (squash) August 26, 2026 16:40
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.80%. Comparing base (fd5da80) to head (5dc5449).

Files with missing lines Patch % Lines
...dsList/GiftCardsListHeader/GiftCardsListHeader.tsx 0.00% 1 Missing ⚠️
...istDialogsProvider/GiftCardListDialogsProvider.tsx 0.00% 1 Missing ⚠️
...nents/ProductExportDialog/ExportDialogSettings.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6875      +/-   ##
==========================================
+ Coverage   56.73%   56.80%   +0.06%     
==========================================
  Files        3541     3537       -4     
  Lines       73085    73007      -78     
  Branches    18917    18519     -398     
==========================================
  Hits        41468    41468              
- Misses      29695    30885    +1190     
+ Partials     1922      654    -1268     
Flag Coverage Δ
storybook 50.16% <ø> (ø)
units 51.96% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkostrowski
lkostrowski merged commit 070d0e6 into main Aug 26, 2026
15 of 17 checks passed
@lkostrowski
lkostrowski deleted the lkostrowski/staging-schema-attribute-fields-v1 branch August 26, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants