Add attributes to customer filters - #6876
Merged
Merged
Conversation
mirekm
commented
Aug 26, 2026
Member
Macaw hid the menu when a restored or selected value left the list empty, and a later search could overwrite a newer fetch. Load options on focus, keep the current value in the list, and drop stale responses.
Filter comboboxes assumed you would type to search, so they asked Saleor for five rows and never paginated. Load the usual search page size, append on scroll, drop a stale cursor when the field changes, and restore every selected value from the URL.
mirekm
requested review from
a team and
przlada
and
a lite review from Copilot
August 26, 2026 21:59
🦋 Changeset detectedLatest commit: be41e60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6876 +/- ##
==========================================
- Coverage 56.81% 56.78% -0.04%
==========================================
Files 3537 3542 +5
Lines 73031 73484 +453
Branches 18900 18650 -250
==========================================
+ Hits 41491 41725 +234
- Misses 29621 31077 +1456
+ Partials 1919 682 -1237
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lkostrowski
approved these changes
Aug 27, 2026
mirekm
enabled auto-merge (squash)
August 27, 2026 06:17
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.