Skip to content

Add attributes to customer filters - #6876

Merged
mirekm merged 6 commits into
mainfrom
feat/customer-attribute-filters
Aug 27, 2026
Merged

Add attributes to customer filters#6876
mirekm merged 6 commits into
mainfrom
feat/customer-attribute-filters

Conversation

@mirekm

@mirekm mirekm commented Aug 26, 2026

Copy link
Copy Markdown
Member
image

mirekm added 5 commits August 26, 2026 23:53
Macaw hid the menu when a restored or selected value left the list empty, and a later search could overwrite a newer fetch. Load options on focus, keep the current value in the list, and drop stale responses.
Filter comboboxes assumed you would type to search, so they asked Saleor for five rows and never paginated. Load the usual search page size, append on scroll, drop a stale cursor when the field changes, and restore every selected value from the URL.
@mirekm
mirekm requested review from a team and przlada and a lite review from Copilot August 26, 2026 21:59
@changeset-bot

changeset-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: be41e60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mirekm
mirekm requested review from lkostrowski and removed request for przlada August 26, 2026 22:01
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 48.10544% with 315 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.78%. Comparing base (7002c5a) to head (be41e60).

Files with missing lines Patch % Lines
...components/ConditionalFilter/useFilterContainer.ts 3.93% 105 Missing and 17 partials ⚠️
...ilter/API/initialState/loadAttributeFilterState.ts 10.86% 38 Missing and 3 partials ⚠️
.../components/ConditionalFilter/UI/RightOperator.tsx 5.00% 16 Missing and 3 partials ⚠️
src/components/ConditionalFilter/API/Handler.ts 59.52% 16 Missing and 1 partial ⚠️
.../initialState/customers/useInitialCustomerState.ts 25.00% 14 Missing and 1 partial ⚠️
src/components/ConditionalFilter/UI/Row.tsx 15.38% 10 Missing and 1 partial ⚠️
...Filter/API/providers/CustomerFilterAPIProvider.tsx 30.76% 8 Missing and 1 partial ⚠️
src/components/ConditionalFilter/FiltersArea.tsx 0.00% 5 Missing and 3 partials ⚠️
...yVarsBuilders/AssignedAttributeQueryVarsBuilder.ts 88.23% 8 Missing ⚠️
...er/API/providers/ProductTypesFilterAPIProvider.tsx 14.28% 6 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6876      +/-   ##
==========================================
- Coverage   56.81%   56.78%   -0.04%     
==========================================
  Files        3537     3542       +5     
  Lines       73031    73484     +453     
  Branches    18900    18650     -250     
==========================================
+ Hits        41491    41725     +234     
- Misses      29621    31077    +1456     
+ Partials     1919      682    -1237     
Flag Coverage Δ
storybook 49.50% <7.81%> (-0.67%) ⬇️
units 51.96% <47.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI review requested due to automatic review settings August 27, 2026 06:17
@mirekm
mirekm enabled auto-merge (squash) August 27, 2026 06:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mirekm
mirekm merged commit ce6966f into main Aug 27, 2026
14 of 17 checks passed
@mirekm
mirekm deleted the feat/customer-attribute-filters branch August 27, 2026 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants