Skip to content

Update lists filtering component - #6879

Merged
mirekm merged 8 commits into
mainfrom
feat/variant-reference-filter-grouping
Aug 27, 2026
Merged

Update lists filtering component#6879
mirekm merged 8 commits into
mainfrom
feat/variant-reference-filter-grouping

Conversation

@mirekm

@mirekm mirekm commented Aug 27, 2026

Copy link
Copy Markdown
Member
image

mirekm added 2 commits August 27, 2026 12:06
A flat variant page hid the size behind a long product name and listed the same product once per variant.
Copilot AI lite review requested due to automatic review settings August 27, 2026 10:26
@changeset-bot

changeset-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9833033

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.61998% with 233 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.08%. Comparing base (bc08ccf) to head (9833033).

Files with missing lines Patch % Lines
...nditionalFilter/UI/VariantReferenceMultiselect.tsx 72.83% 19 Missing and 3 partials ⚠️
...nditionalFilter/UI/ProductReferenceMultiselect.tsx 69.11% 18 Missing and 3 partials ⚠️
...onditionalFilter/UI/SwatchAttributeMultiselect.tsx 70.00% 18 Missing and 3 partials ⚠️
...lFilter/UI/ProductReferenceMultiselect.stories.tsx 0.00% 16 Missing ⚠️
...lFilter/UI/VariantReferenceMultiselect.stories.tsx 0.00% 16 Missing ⚠️
...alFilter/UI/SwatchAttributeMultiselect.stories.tsx 0.00% 15 Missing ⚠️
...omponents/ConditionalFilter/LoadingFiltersArea.tsx 12.50% 14 Missing ⚠️
.../components/ConditionalFilter/UI/RightOperator.tsx 50.00% 9 Missing and 3 partials ⚠️
src/components/ConditionalFilter/UI/Root.tsx 0.00% 9 Missing ⚠️
src/components/ConditionalFilter/API/Handler.ts 78.37% 7 Missing and 1 partial ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6879      +/-   ##
==========================================
+ Coverage   56.78%   57.08%   +0.30%     
==========================================
  Files        3542     3559      +17     
  Lines       73488    74083     +595     
  Branches    19034    18813     -221     
==========================================
+ Hits        41728    42290     +562     
- Misses      29813    31113    +1300     
+ Partials     1947      680    -1267     
Flag Coverage Δ
storybook 49.60% <41.49%> (+0.09%) ⬆️
units 52.36% <71.41%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mirekm added 5 commits August 27, 2026 12:56
…order as Filters

Saleor rejects AttributeInput lists that mix deprecated values with value, so product attributes now send value only. List search uses the existing bordered field, and filter drafts clone so Close no longer shares mutated state with Apply.
Global select-option flex rules stretched color swatches, and the variant
assign payload overwrote Product: Variant with the bare variant name.
Copilot AI review requested due to automatic review settings August 27, 2026 11:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mirekm
mirekm marked this pull request as ready for review August 27, 2026 11:57
@mirekm
mirekm requested review from a team, Copilot and wcislo-saleor August 27, 2026 11:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@mirekm
mirekm merged commit 255a40f into main Aug 27, 2026
16 of 18 checks passed
@mirekm
mirekm deleted the feat/variant-reference-filter-grouping branch August 27, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants