refactor: gate webhook secretKey to the main schema - #6928
Draft
lkostrowski wants to merge 1 commit into
Draft
Conversation
secretKey is removed from Webhook, WebhookCreateInput and WebhookUpdateInput in 3.24, so staging builds must stop reading and sending it. Uses the existing @lockSchema mechanism to keep one document serving both schemas, and gates the form field and mutation input behind isMainSchema(). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6928 +/- ##
=========================================
Coverage 58.16% 58.17%
=========================================
Files 3394 3394
Lines 73710 73715 +5
Branches 19357 19305 -52
=========================================
+ Hits 42876 42885 +9
- Misses 28966 30671 +1705
+ Partials 1868 159 -1709
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
secretKey is removed from Webhook, WebhookCreateInput and WebhookUpdateInput in 3.24, so staging builds must stop reading and sending it. Uses the existing @lockSchema mechanism to keep one document serving both schemas, and gates the form field and mutation input behind isMainSchema().
Scope of the change