Use single allocation to store origin and QueryRevisionExtra#1112
Merged
MichaReiser merged 7 commits intoJun 10, 2026
Merged
Conversation
QueryRevisionExtra
✅ Deploy Preview for salsa-rs canceled.
|
✅ Deploy Preview for salsa-rs canceled.
|
072d3ae to
1e0667c
Compare
Merging this PR will improve performance by 5.79%
Performance Changes
Tip Curious why this is faster? Comment Comparing |
0f537ff to
eba3425
Compare
262e64c to
f26c8f5
Compare
f26c8f5 to
42c6788
Compare
42c6788 to
918c48c
Compare
carljm
approved these changes
Jun 9, 2026
carljm
left a comment
Contributor
There was a problem hiding this comment.
Looks reasonable to me! Neat optimization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #1101, the layout for a memo with extra data is:
Note how this requires two boxes. One to
IndirectOriginAndExtraand another for the query edges.This PR avoids the two boxes by using a custom DST that stores the
QueryRevisionExtraas Header and the origin edges as slice, both using the sameBoxThe memory gains on ty are marginal, but walltime of cycle heavy projects improve by 10% (20% fewer allocations)!
astral-sh/ruff#25774