Moved styling for informationPanel into its own .scss-file#279
Open
muildrik wants to merge 2 commits intosamvera-labs:mainfrom
Open
Moved styling for informationPanel into its own .scss-file#279muildrik wants to merge 2 commits intosamvera-labs:mainfrom
muildrik wants to merge 2 commits intosamvera-labs:mainfrom
Conversation
mathewjordan
force-pushed
the
main
branch
3 times, most recently
from
a9af10c to
a90ceb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a first attempt of moving the styling out of the informationPanel component into its own .scss-file. This will definitely be a lot more manageable than having to deal with Stitched and I think, as you said, provides maximum flexibility for overall styling.
There's a few ways to organize this, but I think the best way is probably to define one .scss-file for each component, with its subcomponents in there, and then @use/@forward them in a single global file. That way it should be fairly straightforward to track how a particular part of the application can be styled outside of JSX. We can then come up with a solution to style via JSX if you wanted to do that.
In the docs we do want to clarify what we mean by component, subcomponent, and perhaps even element. Below a little graphic we can use to organize what I would call the elements of the Viewer Component: the header, canvas, informationPanel and navigation. The subcomponents would be the smaller bits within it such as the navigation buttons in the navigation element.
Thoughts?