The InformationPanel now lives at the same level as ViewerHeader and …#282
Open
muildrik wants to merge 7 commits intosamvera-labs:mainfrom
Conversation
…ViewerContent. To do so we use the grid instead of flexbox. All props passed to InformationPanel can be retrieved from state/store if my previous PRs are merged in. We should check if isInformationOpen and setInformationOpen still work as they should, but otherwise the Collapsible Radix component can be removed.
…erContent-and-ViewerHeader
…not seem to break anything. I commented out a bunch of the tests that are giving me a hard time to figure out (I'm still learning about unit testing in React). Can you confirm this looks ok?
…nel-to-same-level-as-ViewerContent-and-ViewerHeader
mathewjordan
force-pushed
the
main
branch
3 times, most recently
from
a9af10c to
a90ceb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ViewerContent. To do so we use the grid instead of flexbox. All props passed to InformationPanel can be retrieved from state/store if my previous PRs are merged in. We should check if isInformationOpen and setInformationOpen still work as they should, but otherwise the Collapsible Radix component can be removed.