Merged
Conversation
kirkkwang
reviewed
Mar 2, 2026
kirkkwang
approved these changes
Mar 2, 2026
Contributor
kirkkwang
left a comment
kirkkwang
left a comment
There was a problem hiding this comment.
Nice, I think this looks good, a question that I had would be is are we breaking CI for Hyku 6 apps that don't have hyku_knapsack pinned?
Contributor
Author
Yes, this would be a breaking change. But I included instructions in readme that hopefully would help 🤔 I'll bring it by Rob's office hr though to talk versioning strategies again. |
ShanaLMoore
commented
Mar 3, 2026
- Dockerfile: use rails instead of rake (secret, assets:precompile) - Set HYRAX_FLEXIBLE and HYRAX_DISABLE_INCLUDE_METADATA early in lib/hyku_knapsack.rb - Engine: load knapsack initializers after host app; disable *_include_metadata in flexible mode; use schema_loader_config_search_paths.unshift instead of SimpleSchemaLoaderDecorator - config/initializers/hyrax.rb: config.flexible from ENV, prepend schema search path - spec/rails_helper.rb: set HYRAX_FLEXIBLE before requiring Rails - Remove SimpleSchemaLoaderDecorator (replaced by Hyku 7 config API) - Bump version to 1.0.0 and require rails >= 7.2.0 in gemspec - Update hyrax-webapp submodule for Hyku 7 BREAKING: Incompatible with Hyku 6.x / Rails 6; use v0.0.1 for older stacks. ISSUE: - notch8/hyku-community-issues#44
- Stop setting ENV['HYRAX_FLEXIBLE'] in lib/hyku_knapsack.rb; let the app control it - Default config.flexible and include_metadata logic to false (Hyku default) - Specs use HYRAX_FLEXIBLE=false unless set elsewhere; set true in tests that need flexible mode Flexible metadata remains opt-in via HYRAX_FLEXIBLE=true in .env or docker-compose.
ShanaLMoore
force-pushed
the
hyku-7-support
branch
from
85ed656 to
aa551c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story
Issue:
Expected Behavior Before Changes
Repo wouldn't spin up when Hyku 7 was its submodule
Expected Behavior After Changes
Repo runs with Hyku7
Summary of changes
hyrax-webappat Hyku 7 (e.g.v7.0.0.rc1ormain).railsinstead ofrakewhere required; gemspec requiresrails >= 7.2.0.HYRAX_FLEXIBLEearly, useschema_loader_config_search_pathsfor knapsack schemas, removeSimpleSchemaLoaderDecoratorin favor of config.v0.0.1-hyku6-compatand branchhyku-6-supportpreserved for knapsacks still on Hyku 6.Breaking change
v1.0.0 is not compatible with Hyku 6.x. Downstream knapsacks on Hyku 6 should use
ref: 'v0.0.1-hyku6-compat'orbranch: 'hyku-6-support'(see README).Notes
v0.0.1-hyku6-compatand branchhyku-6-supportbefore these changes.required_for_knapsack_instances; prime keeps that branch in sync withmainfor Hyku 7.