Align version strategy with Hyku; document in README#46
Merged
ShanaLMoore merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
Contributor
ShanaLMoore
commented
Mar 3, 2026
- Document version alignment: Knapsack major version matches Hyku series (6→6, 7→7)
- Clarify Installation: clone Knapsack at desired version; submodule is already pinned to a compatible Hyku commit—no editing Hyku or submodule Gemfile
- Reference .gitmodules for submodule pointer; remove literal branch/tag examples
- Clean version.rb: remove test constant, keep VERSION 6.0.0
ad6349d to
c84db68
Compare
kirkkwang
reviewed
Mar 3, 2026
kirkkwang
approved these changes
Mar 3, 2026
Contributor
kirkkwang
left a comment
There was a problem hiding this comment.
I think that looks good! Just left a non-blocking comment.
c84db68 to
98d3097
Compare
- Document version alignment: Knapsack major version matches Hyku series (6→6, 7→7) - Clarify Installation: clone Knapsack at desired version; submodule is already pinned to a compatible Hyku commit—no editing Hyku or submodule Gemfile - Reference .gitmodules for submodule pointer; remove literal branch/tag examples - Clean version.rb: remove test constant, keep VERSION 6.0.0 Made-with: Cursor
98d3097 to
7c4e8c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.