Skip to content

Blastn fix#248

Merged
muffato merged 2 commits into
devfrom
blast_fix
Jun 29, 2026
Merged

Blastn fix#248
muffato merged 2 commits into
devfrom
blast_fix

Conversation

@muffato

@muffato muffato commented Jun 25, 2026

Copy link
Copy Markdown
Member

Here I reintroduce the taxonomy db symlinks that turn out to be necessary.

I think we didn't notice before because:

  • the test profile doesn't have any blastn hits (blastn only errors about the db missing if there's a hit, otherwise it's only a warning)
  • the test_full profile doesn't even run blastn

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@muffato muffato self-assigned this Jun 25, 2026
@sanger-tolsoft

Copy link
Copy Markdown
Contributor

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ff38309

+| ✅ 202 tests passed       |+
#| ❔  30 tests were ignored |#
!| ❗  18 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-blobtoolkit_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: conf/igenomes.config
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: .gitattributes
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: assets/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-blobtoolkit_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-blobtoolkit_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/blobtoolkit/blobtoolkit/.github/workflows/awstest.yml
  • template_strings - template_strings
  • merge_markers - merge_markers

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-06-29 13:28:50

@muffato

muffato commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

Not opening this PR for review just yet as there is another bug on dev I'm still trying to identify and squash

@muffato

muffato commented Jun 27, 2026

Copy link
Copy Markdown
Member Author

Not opening this PR for review just yet as there is another bug on dev I'm still trying to identify and squash

That other issue is in another part of the pipeline. Will address it in another PR.

@muffato
muffato marked this pull request as ready for review June 27, 2026 16:10
@muffato
muffato changed the base branch from dev to main_to_dev June 29, 2026 11:54
Base automatically changed from main_to_dev to dev June 29, 2026 12:22
@muffato
muffato force-pushed the blast_fix branch 2 times, most recently from 6cee371 to 3755969 Compare June 29, 2026 12:35

@sainsachiko sainsachiko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just minor comment

Comment thread modules/nf-core/blast/blastn/main.nf Outdated
Co-authored-by: Hanh Hoang <134130358+sainsachiko@users.noreply.github.com>
@muffato

muffato commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

Fixed. And the tests still pass

@muffato
muffato merged commit e223342 into dev Jun 29, 2026
16 of 19 checks passed
@muffato
muffato deleted the blast_fix branch June 29, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants