Conversation
Contributor
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
Member
Author
|
Not opening this PR for review just yet as there is another bug on |
Member
Author
That other issue is in another part of the pipeline. Will address it in another PR. |
muffato
force-pushed
the
blast_fix
branch
2 times, most recently
from
June 29, 2026 12:35
6cee371 to
3755969
Compare
sainsachiko
reviewed
Jun 29, 2026
sainsachiko
left a comment
Contributor
There was a problem hiding this comment.
LGTM! just minor comment
Co-authored-by: Hanh Hoang <134130358+sainsachiko@users.noreply.github.com>
Member
Author
|
Fixed. And the tests still pass |
sainsachiko
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I reintroduce the taxonomy db symlinks that turn out to be necessary.
I think we didn't notice before because:
testprofile doesn't have any blastn hits (blastn only errors about the db missing if there's a hit, otherwise it's only a warning)test_fullprofile doesn't even run blastnPR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).