Add versioning and verbose option to script#11
Merged
Merged
Conversation
Still trying to use python syntax
|
Can you post the output of |
Collaborator
Author
the package errors should dissapear in the CI, pretty sure it's just because i've had to fresh install the R packages to test. |
prototaxites
approved these changes
Mar 20, 2026
| suppressMessages(library(tidyverse)) | ||
| suppressMessages(library(scales)) | ||
|
|
||
| version <- "1.0.0" |
There was a problem hiding this comment.
Question, should this actually be 1.0.1 now 🙋♂️
Collaborator
Author
There was a problem hiding this comment.
...yes, yes it should. Done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually add a versions output to the script, issue brought up by @prototaxites on sanger-tol/nf-core-modules#212
I think this should do it?