Skip to content

Update pattern and params.json#478

Merged
weaglesBio merged 3 commits into
devfrom
471-fixes
Jun 18, 2026
Merged

Update pattern and params.json#478
weaglesBio merged 3 commits into
devfrom
471-fixes

Conversation

@DLBPointon

Copy link
Copy Markdown
Contributor

Addition of the fq pattern to input reads
Remove outdir from params.json, hold over from previous PR.

@DLBPointon
DLBPointon requested a review from weaglesBio June 10, 2026 09:18
@DLBPointon DLBPointon self-assigned this Jun 10, 2026
@DLBPointon

Copy link
Copy Markdown
Contributor Author

@weaglesBio has pointed out we need a test data set to ensure this works as intended.

@sanger-tolsoft

Copy link
Copy Markdown
Contributor

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3cb8843

+| ✅ 220 tests passed       |+
#| ❔  30 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗  10 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.4.7
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: ## Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • system_exit - System.exit in treeval.nf: System.exit(1) [line 113]
  • system_exit - System.exit in treeval.nf: System.exit(1) [line 120]

❔ Tests ignored:

  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: assets/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_exist - File is ignored: conf/test_full.config
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_dark.png
  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: .gitattributes
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: assets/nf-core-treeval_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-treeval_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-treeval_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/treeval/treeval/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-06-11 10:21:29

@DLBPointon DLBPointon mentioned this pull request Jun 10, 2026
@weaglesBio

Copy link
Copy Markdown
Contributor

Fastq parsing will be resolved as a separate issue #470

@weaglesBio
weaglesBio merged commit ed1730b into dev Jun 18, 2026
7 of 8 checks passed
@weaglesBio
weaglesBio deleted the 471-fixes branch June 18, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants