Skip to content

Dev2Main - 1.4.8#477

Merged
DLBPointon merged 16 commits into
mainfrom
dev
Jun 10, 2026
Merged

Dev2Main - 1.4.8#477
DLBPointon merged 16 commits into
mainfrom
dev

Conversation

@DLBPointon

Copy link
Copy Markdown
Contributor

Updates docs
Updates input.yaml handling
Remove unnecessary values from yaml and yaml_input
Add proposal for treeval V2 inputs

Shouldn't effect any of the production scripts. @weaglesBio

@sanger-tolsoft

Copy link
Copy Markdown
Contributor

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 12a423b

+| ✅ 220 tests passed       |+
#| ❔  30 tests were ignored |#
#| ❔   1 tests had warnings |#
!| ❗  10 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.4.7
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in nextflow.config: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in methods_description_template.yml: ## Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • system_exit - System.exit in treeval.nf: System.exit(1) [line 113]
  • system_exit - System.exit in treeval.nf: System.exit(1) [line 120]

❔ Tests ignored:

  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: assets/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_exist - File is ignored: conf/test_full.config
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-treeval_logo_dark.png
  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: .gitattributes
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: assets/nf-core-treeval_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-treeval_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-treeval_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/treeval/treeval/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

❔ Tests fixed:

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.2
  • Run at 2026-06-09 20:34:00

@weaglesBio weaglesBio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but is it worth including the fastq change into this release?

@DLBPointon

Copy link
Copy Markdown
Contributor Author

Looks good, but is it worth including the fastq change into this release?

Yes it is, sorry thought we already did that.

@DLBPointon
DLBPointon merged commit ef06981 into main Jun 10, 2026
13 checks passed
Comment thread assets/local_testing/nxOscDF5033-BGA.yaml
Comment thread assets/local_testing/nxOscDF5033-BGA.yaml
Comment thread assets/local_testing/nxOscDF5033-BGA.yaml
Comment thread assets/treeval_v2_input_proposal/params.json
Comment thread docs/output.md
Comment thread docs/output.md
- `maxdepth.bigbed`: Max read depth punchlist in bigBed format.
- `zerodepth.bigbed`: Zero read depth punchlist in bigBed format.
- `halfcoverage.bigbed`: Half read depth punchlist in bigBed format.
- `maxdepth.bed`: Max read depth punchlist in bed format.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read depth > 1000

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? As in maxdepth == reads where coverage > 1000?

Comment thread docs/output.md
Comment thread docs/usage.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants