Skip to content

sap_vm_provision/kubevirt_vm: Make evictionStrategy configurable #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newkit merged 2 commits into from
Aug 6, 2026
Merged

sap_vm_provision/kubevirt_vm: Make evictionStrategy configurable #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09e50f4
sap_vm_provision/kubevirt_vm: Make evictionStrategy configurable
aisa-b Aug 2, 2026
cb4e090
Address review: add eviction_strategy input validation
aisa-b Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions roles/sap_vm_provision/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,10 @@ sap_vm_provision_kubevirt_vm_os_user_password: ""
# RAM Overhead [GiB] for virt-launcher container, this can be small for VMs < 1 TB and without SRIOV but should be increased to 16 or more for VMs > 1TB
sap_vm_provision_kubevirt_vm_container_memory_overhead: 1

# Eviction strategy for KubeVirt VMs (String).
# Set to 'None' for local storage (ReadWriteOnce PVCs) or 'LiveMigrate' for shared storage (ReadWriteMany).
sap_vm_provision_kubevirt_vm_eviction_strategy: "None"
Comment thread
marcelmamula marked this conversation as resolved.

# CPU performance settings which are applied to VM
# Note: Using dedicatedCpuPlacement=true together with numa.guestMappingPassthrough requires also usage of huge pages
sap_vm_provision_kubevirt_vm_performance_cpu_settings:
Expand Down
2 changes: 1 addition & 1 deletion roles/sap_vm_provision/tasks/platform_ansible/kubevirt_vm/execute_provision.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,11 @@
__sap_vm_provision_fact_vm_deploy_config:
volumes: "{{ __sap_vm_provision_fact_storage_disk_name_list + __sap_vm_provision_fact_cloud_init_volume }}"
networks: "{{ __sap_vm_provision_fact_networks_definition }}"
evictionStrategy: "{{ sap_vm_provision_kubevirt_vm_eviction_strategy }}"
Comment thread
marcelmamula marked this conversation as resolved.
domain:
# shared | auto, auto prevents live migration
ioThreadsPolicy: shared
hostname: "{{ __sap_vm_provision_fact_vm_name }}"
evictionStrategy: LiveMigrate
terminationGracePeriodSeconds: 1800 # 30 minutes after stop request before VM is force terminated
resources:
requests:
Expand Down
12 changes: 12 additions & 0 deletions roles/sap_vm_provision/tasks/validations/kubevirt_vm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# SPDX-License-Identifier: Apache-2.0
---

- name: Assert that the variable 'sap_vm_provision_kubevirt_vm_eviction_strategy' is defined as valid string
ansible.builtin.assert:
that:
- sap_vm_provision_kubevirt_vm_eviction_strategy is defined
- sap_vm_provision_kubevirt_vm_eviction_strategy is string
- sap_vm_provision_kubevirt_vm_eviction_strategy in ['None', 'LiveMigrate']
fail_msg: |
The variable 'sap_vm_provision_kubevirt_vm_eviction_strategy' is undefined or invalid.
It should be one of: 'None' for local storage (ReadWriteOnce PVCs) or 'LiveMigrate' for shared storage (ReadWriteMany).