Skip to content

sap_hana_install: Enhance SAPCAR detection functionality and handling of multiple files - #1082

Merged
berndfinger merged 3 commits into
sap-linuxlab:devfrom
marcelmamula:sapcar_hana
Jul 28, 2025
Merged

sap_hana_install: Enhance SAPCAR detection functionality and handling of multiple files#1082
berndfinger merged 3 commits into
sap-linuxlab:devfrom
marcelmamula:sapcar_hana

Conversation

@marcelmamula

@marcelmamula marcelmamula commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Changes

  • Replace existing complex shell commands for SAPCAR OS Architecture detection and identification of latest SAPCAR:
  • Added dynamic jinja2 fail messages depending on conditions.
  • Added fail check if SAR files were not found.
  • Added lot of comments to explain logic behind tasks as well as missing explanations.

Tested

This code change was tested on SLES_SAP 15 SP6 and SLES_SAP 16 RC2.

NOTE for testing: Executing role sap_install_media_detect beforehand will skip SAPCAR and SAR file tasks, because extracted folder is prepared already.

@marcelmamula
marcelmamula requested a review from berndfinger July 23, 2025 14:12
@marcelmamula marcelmamula self-assigned this Jul 23, 2025
@marcelmamula marcelmamula added the enhancement New feature or request label Jul 23, 2025

@berndfinger berndfinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested the selection of the correct SAPCAR*EXE file on x86_64, ppc64le and s390x managed nodes with all available SAPCAR files, on x86_64 with two different versions and with and without checksum file.

See also my other comments which are part of this review.

Comment thread roles/sap_hana_install/tasks/pre_install/prepare_sapcar.yml Outdated
Comment thread roles/sap_hana_install/tasks/pre_install/prepare_sapcar.yml Outdated
Comment thread roles/sap_hana_install/tasks/pre_install/prepare_sapcar.yml Outdated
@marcelmamula

Copy link
Copy Markdown
Contributor Author

@berndfinger All open changes were fixed and I added extra rescue block to remove temporary file __EXTRACTION_ONGOING__.

@berndfinger berndfinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I successfully tested the selection of the correct SAPCAR*EXE file on x86_64, ppc64le and s390x managed nodes with all available SAPCAR files, on x86_64 with two different versions and with and without checksum file.

Thanks for this contribution and also for adding the handling of the status/lock file in case of failures!

LGTM!

@berndfinger
berndfinger merged commit c781a8b into sap-linuxlab:dev Jul 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants