sap_hana_install: Enhance SAPCAR detection functionality and handling of multiple files - #1082
Conversation
berndfinger
left a comment
There was a problem hiding this comment.
I successfully tested the selection of the correct SAPCAR*EXE file on x86_64, ppc64le and s390x managed nodes with all available SAPCAR files, on x86_64 with two different versions and with and without checksum file.
See also my other comments which are part of this review.
|
@berndfinger All open changes were fixed and I added extra rescue block to remove temporary file |
berndfinger
left a comment
There was a problem hiding this comment.
I successfully tested the selection of the correct SAPCAR*EXE file on x86_64, ppc64le and s390x managed nodes with all available SAPCAR files, on x86_64 with two different versions and with and without checksum file.
Thanks for this contribution and also for adding the handling of the status/lock file in case of failures!
LGTM!
Changes
sap_swpmrole where SWPM files need to be identified as well. sap_swpm: Incorrect handling of multiple files with same name #1031Tested
This code change was tested on SLES_SAP 15 SP6 and SLES_SAP 16 RC2.
NOTE for testing: Executing role
sap_install_media_detectbeforehand will skip SAPCAR and SAR file tasks, because extracted folder is prepared already.