sap_hana_preconfigure: Replace grub2-mkconfig for RHEL by grubby from RHEL 8 onward - #1083
Merged
berndfinger merged 11 commits intoJul 25, 2025
Conversation
Solves sap-linuxlab#1081. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#1081. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#1081. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
- Only use dict contents for determining kernel command line dependencies for RHEL releases - Set and display the grubby command line before calling the handler Signed-off-by: Bernd Finger <bfinger@redhat.com>
ja9fuchs
approved these changes
Jul 24, 2025
ja9fuchs
left a comment
ja9fuchs
left a comment
Contributor
There was a problem hiding this comment.
lgtm 👍
nice one with the "plus" files :)
marcelmamula
requested changes
Jul 25, 2025
marcelmamula
left a comment
marcelmamula
left a comment
Contributor
There was a problem hiding this comment.
Test done on SLES_SAP 16 and fewe comments are added.
TASK [community.sap_install.sap_hana_preconfigure : Include OS specific vars, specific] **************************************************
[started TASK: community.sap_install.sap_hana_preconfigure : Include OS specific vars, specific on h02hana0]
skipping: [h02hana0] => (item=Suse.yml)
skipping: [h02hana0] => (item=SLES_SAP.yml)
skipping: [h02hana0] => (item=SLES_16.yml)
skipping: [h02hana0] => (item=SLES_16.0.yml)
ok: [h02hana0] => (item=SLES_SAP_16.yml)
skipping: [h02hana0] => (item=SLES_SAP_16.0.yml)
berndfinger
force-pushed
the
issue-1081-grub2-mkconfig-command-line-args-rhel93
branch
from
July 25, 2025 10:13
0d290c0 to
0ccc97f
Compare
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
marcelmamula
approved these changes
Jul 25, 2025
marcelmamula
left a comment
marcelmamula
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you for correcting issues we found.
berndfinger
deleted the
issue-1081-grub2-mkconfig-command-line-args-rhel93
branch
July 25, 2025 14:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1081. I used the opportunity to define the boot command line arguments in vars files and add the logic for loading vars files for RHEL to also support "greater than" operations for RHEL minor releases (so that the latest versions of a vars file is loaded even when using a higher minor RHEL version). I also cleaned up some vars files because each additional vars file entry will either replace an existing one or it will be appended to already loaded vars.
@marcelmamula SLES should not be affected. All handlers are left in place except those for RHEL which are no longer needed.