sap_ha_pacemaker_cluster: Enhance handling of cluster properties and improve ASCS ERS post steps - #1084
Merged
Merged
Conversation
ja9fuchs
approved these changes
Jul 29, 2025
ja9fuchs
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
Tested successfully on RHEL 9.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for changes
HAGetFailoverConfigbecause Sapstartsrv was not loaded with cluster connector.Changes
sap_ha_pacemaker_cluster_cluster_propertiesto enable proper loading of user defined versus predefined.concurrent-fencingbecause it is used only by HANA Scaleout and Azure HA (separate tasks).priority-fencing-delaywhich was incorrectly pointing towards previous structure of__sap_ha_pacemaker_cluster_stonith_default__sap_ha_pacemaker_cluster_cluster_properties_defaultand platform specific__sap_ha_pacemaker_cluster_cluster_properties_platformdefinition of cluster properties. Allstonith-timeoutvalues are defined based on documentations we could find.priority: 100was added to align withpriority-fencing-delayTested
Changes were tested on:
NOTE: We have agreed with @ja9fuchs that load order for
ha_clustervariables have to be changed in future, to ensure thatsap_ha_pacemaker_clustervariables take precedence over them, but this PR was done in alignment with current state (Although comments were added for future reference).