sap_swpm: Replace SAP detection fail with warning for wrong GID and UID - #1231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#1213 brought a lot of improvements including much stricter validations.
One of them was bit too strict as re-testing has showed that
sapinsthas some leniency when handling existing users and groups.failmodules todebugto showWARNinstead.Test results
Accepts:
sidadmandsapadmwith different IDs.sapsyswith different ID.Rejects:
ae1adm GID: 3333and ERS withae1adm GID: 3334NOTE: This is specific only to distributed systems with shared filesystems!
HANA Details
sap_hana_install, because of its own strict behavior documented in test section below.Test results
Accepts:
sidadmpassword provided in parameter file underpassword=Rejects:
sidadmpassword provided in parameter file underpassword=sidadmpassword provided in parameter file underpassword=