all: Replace inject vars with ansible_facts for 2.20 - #59
Merged
Conversation
berndfinger
approved these changes
Mar 17, 2026
berndfinger
left a comment
berndfinger
left a comment
Member
There was a problem hiding this comment.
LGTM. Tested with S/4HANA 2025 on RHEL 10 on premise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updated all injected vars to
ansible_factsin order to remove deprecation warning foransible-core 2.20.Replaced vars:
Tests
Tested on SLES_SAP 16.0 on premise.