sap_software_download: Install required package on RHEL 10 - #79
Merged
berndfinger merged 1 commit intoJul 27, 2026
Merged
Conversation
Fixes issue sap-linuxlab#77. This is necessary because the Python packaging library is no longer bundled in python3-setuptools and python3-pip in the default Python (3.12) in RHEL 10. Signed-off-by: Bernd Finger <bfinger@redhat.com>
marcelmamula
approved these changes
Jul 27, 2026
marcelmamula
left a comment
marcelmamula
left a comment
Contributor
There was a problem hiding this comment.
LGTM as changes requested in #78 (review) were completed.
rhmk
approved these changes
Jul 27, 2026
Member
There was a problem hiding this comment.
The fix solves the problem, so LGTM.
From my point of view, it would be more elegant to change the variable with the Python package to a list containing the package, the pip package, and the additional packages. But I am also fine with this solution.
- name: SAP Software Download - Prepare - Install Python and Python package manager pip
ansible.builtin.package:
name: "{{ __sap_software_download_fact_python_packages }}"
state: present
And then change all the header files for each OS (more complex, but more elegant code) It would avoid a when branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #77.
This is necessary because the Python packaging library is no longer bundled in python3-setuptools and python3-pip in the default Python (3.12) in RHEL 10.
Tested on RHEL 9.8, 10.0 and 10.2 managed nodes, with and without
sap_software_download_use_venv: true.