workflow: Fix errors from ansible-test action

[marcelmamula]

Premise

CI Action provided by Ansible team must be executed and passing in order to mark our collection as maintained and in good shape.

Changes

• Workflow
  • Update triggers, remove unused integration commented out code and add ansible/python matrix.
• Sanity tests
  • Add ignore files for missing ansible versions plus devel (2.20), which will fail in future when 2.21 will come.
  • Remove pylint:use-yield-from
• Unit tests
  • Implement fix from https://forum.ansible.com/t/making-a-collection-compatible-with-core-2-19-and-templating-changes/41717/2

Tests

Tests were done by CI workflow in question.

[felixfontein]

Regarding your latest CI failures, this might help: https://forum.ansible.com/t/making-a-collection-compatible-with-core-2-19-and-templating-changes/41717/2

[marcelmamula]

@felixfontein @samccann Issues were resolved and CI test has passed https://github.com/sap-linuxlab/community.sap_libs/actions/runs/17938922936

I might have overshot some changes so I will test it out separately as this was not meant to be refactor. If I find that I can do with less changes, I will raise separate PR.

[marcelmamula]

Regarding your latest CI failures, this might help: https://forum.ansible.com/t/making-a-collection-compatible-with-core-2-19-and-templating-changes/41717/2

@felixfontein CI works now, but I am using python matrix to force specific version. Your fix works, but it does not work on Python 2, which is not supported anyway, but github action will pick it.

I just tried with removed target-python-version and it failed on Python 2.

E     File "/root/ansible_collections/community/sap_libs/tests/unit/compat/mock.py", line 54
E       yield from data_as_list
E                ^
E   SyntaxError: invalid syntax
- generated xml file: /root/ansible_collections/community/sap_libs/tests/output/junit/python2.7-modules-units.xml -

[felixfontein]

If you replace for ... yield by yield from, then it won't work with Python 2 anymore. You have to decide whether you actively want to break support for Python 2 in tests.

[felixfontein]

Your fix works, but it does not work on Python 2, which is not supported anyway, but github action will pick it.

Your collection still supports it by supporting ansible-core versions that support Python 2 on the target side.