Conversation
…ion workflow see https://github.com/cs3org/OCM-API/blob/v1.2.1/IETF-RFC.md Features: - Button to invite remote users to exchange cloudIDs. - WAYF page allowing the receiver of the invite to open and accept the invitation. - Listing of open invitations. - Option to resend, revoke open invitations. Signed-off-by: antoonp <antoon@redblom.com> Co-authored-by: Micke Nordin <kano@sunet.se>
…ion workflow see https://github.com/cs3org/OCM-API/blob/v1.2.1/IETF-RFC.md Features: - Button to invite remote users to exchange cloudIDs. - WAYF page allowing the receiver of the invite to open and accept the invitation. - Listing of open invitations. - Option to resend, revoke open invitations. Signed-off-by: antoonp <antoon@redblom.com> Co-authored-by: Micke Nordin <kano@sunet.se>
- Replaced disallowed constant in cron job with member variable - Fixed route to discovery endpoint and use of providerDomain param - Use single source of truth for dialog route - Added fallback for inviteAcceptDialog using default Nextcloud path - Updated composer.json with "bamarni/composer-bin-plugin": "^1.8" to enable krankerl builds Signed-off-by: Micke Nordin <kano@sunet.se>
- Add `OcmAcceptForm.vue` with `provider` and `token` inputs and Accept/Cancel emits. - Wire icons, imports, and view state (`showManualInvite`). Signed-off-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Micke Nordin <kano@sunet.se>
- Replace separate Provider/Token fields with one `invite` text field.
- Parse invite string as `token@provider`, splitting on the last `@`.
- Emit parsed `{ provider, token }` on accept.
- Show validation error if invite is malformed.
- Updated template and helper text accordingly.
Signed-off-by: Micke Nordin <kano@sunet.se>
- Inject IOCMDiscoveryService into FederatedInvitesController. - Replace manual URL parsing and hardcoded endpoints with `discovery->discover($provider)` for capability-aware provider lookup. - Use discovered capabilities (`invites` or `/invite-accepted`) to decide if provider supports invite acceptance. - Send invite-accepted request to discovered endpoint. - Replace manual `.well-known/ocm` / `/ocm-provider` probing with `getInviteAcceptDialog()` from discovery result. - Simplify error handling and logging for unsupported providers. - Fix cancel bug Signed-off-by: Micke Nordin <kano@sunet.se>
- Use correct key `userID` - Extract userId, email, and displayName once instead of inline. - Add check to ensure recipientProvider, userId, email, and name are all set. - Log error and return 404 JSON response if any required value is missing. - Use extracted variables in payload for consistency and clarity. Signed-off-by: Micke Nordin <kano@sunet.se>
- Refactor parsing into helper `tryParse` - First attempt direct parsing with `@` separator. - If parsing fails, attempt base64 decoding and retry. - Throw error only if both attempts fail. - Allows for handling encoded OCM invites. Signed-off-by: Micke Nordin <kano@sunet.se>
Partial fix highlighting navigation item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EOSC version 0.0.4 rebased on v8.3.2.1