Skip to content

update verify and testbench#32

Merged
n0thingNoob merged 2 commits into
mainfrom
new_verify_update
Jan 18, 2026
Merged

update verify and testbench#32
n0thingNoob merged 2 commits into
mainfrom
new_verify_update

Conversation

@n0thingNoob

Copy link
Copy Markdown
Contributor

Update verify file.

@n0thingNoob n0thingNoob requested review from Jackcuii, Copilot and syifan and removed request for Copilot January 17, 2026 23:02
Copilot AI review requested due to automatic review settings January 17, 2026 23:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR generalizes the verification system from being histogram-specific to supporting multiple kernels (histogram, FIR, AXPY). It updates report messages, refactors test code to reduce duplication, adds environment variable support for program paths, updates default YAML file names, and incorporates changes from the Zeonica_Testbench submodule.

Changes:

  • Generalized report messages by removing "histogram" references
  • Refactored integration tests to use a shared fileExists helper and consolidated file existence checks
  • Added ZEONICA_PROGRAM_YAML environment variable support across verify commands and testbench
  • Updated core program structures to include CompiledII and IndexPerII fields from YAML
  • Updated expected return value in FIR testbench from 12 to 10

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
verify/report.go Removed "HISTOGRAM" prefix from report titles to make them kernel-agnostic
verify/histogram_integration_test.go Added fileExists helper function and refactored tests to check file existence before loading
verify/cmd/verify-histogram/main.go Added environment variable support for program path, updated default filename, and added error handling for verification failures
verify/cmd/verify-fir/main.go New verification command for FIR kernel following the same pattern as histogram verification
verify/cmd/verify-axpy/main.go Refactored to use GenerateReport instead of custom verification logic, added environment variable support
test/testbench/fir/main.go Added environment variable support for program path and corrected expected return value from 12 to 10
test/Zeonica_Testbench Updated submodule commit reference
core/program.go Added CompiledII and IndexPerII fields to support new YAML structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread verify/cmd/verify-histogram/main.go
Comment thread verify/cmd/verify-fir/main.go
Comment thread verify/cmd/verify-axpy/main.go

@Jackcuii Jackcuii left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n0thingNoob n0thingNoob merged commit 3e475b6 into main Jan 18, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants