update verify and testbench#32
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR generalizes the verification system from being histogram-specific to supporting multiple kernels (histogram, FIR, AXPY). It updates report messages, refactors test code to reduce duplication, adds environment variable support for program paths, updates default YAML file names, and incorporates changes from the Zeonica_Testbench submodule.
Changes:
- Generalized report messages by removing "histogram" references
- Refactored integration tests to use a shared
fileExistshelper and consolidated file existence checks - Added
ZEONICA_PROGRAM_YAMLenvironment variable support across verify commands and testbench - Updated core program structures to include
CompiledIIandIndexPerIIfields from YAML - Updated expected return value in FIR testbench from 12 to 10
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| verify/report.go | Removed "HISTOGRAM" prefix from report titles to make them kernel-agnostic |
| verify/histogram_integration_test.go | Added fileExists helper function and refactored tests to check file existence before loading |
| verify/cmd/verify-histogram/main.go | Added environment variable support for program path, updated default filename, and added error handling for verification failures |
| verify/cmd/verify-fir/main.go | New verification command for FIR kernel following the same pattern as histogram verification |
| verify/cmd/verify-axpy/main.go | Refactored to use GenerateReport instead of custom verification logic, added environment variable support |
| test/testbench/fir/main.go | Added environment variable support for program path and corrected expected return value from 12 to 10 |
| test/Zeonica_Testbench | Updated submodule commit reference |
| core/program.go | Added CompiledII and IndexPerII fields to support new YAML structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update verify file.