Bring back word statistics#100
Draft
egli wants to merge 2 commits into
Draft
Conversation
egli
force-pushed
the
main
branch
2 times, most recently
from
78e1e1b to
370274a
Compare
egli
force-pushed
the
main
branch
2 times, most recently
from
f2fe3a8 to
d6a1f06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This basically implements statistics for unknown words.
The remaining challenge is to find out when this thing should trigger. It currently assumes that it will be invoked after all unknown words have been moved to local words and before they have been confirmed. Essentially this is when a production is finished.
But finishing is currently not triggered from daisyproducer2 but from the old Python-based code.
Should I