Open
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #921 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 19 19
Lines 1073 1073
=======================================
Hits 1036 1036
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replace the globby dependency with glob, which supports both CJS and ESM. This resolves compatibility issues with Hardhat v2 which runs CJS internally, as globby has moved to ESM-only in newer versions. - Replace `globby.sync([files])` with `globSync(files)` from glob - Update README documentation links - Use glob v10 for broad Node.js compatibility Addresses sc-forks#912 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
04cb7c3 to
e36cf16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
globbywithglobto resolve CJS/ESM compatibility issuesglobbyv10 is pinned because newer versions are ESM-only, incompatible with Hardhat v2's CJS internals;globsupports both CJS and ESM via conditional exportsglobby.sync([files])→globSync(files)with identical behaviorChanges
plugins/resources/nomiclabs.utils.js— replaceglobby.syncwithglobSyncfromglobpackage.json— swapglobby ^10.0.1forglob ^10.4.5README.md— update documentation link from globby to globyarn.lock— regeneratedTesting
--file test/<glob*>and--testfiles test/<fileName>integration tests both pass, confirming glob pattern matching works identicallyAddresses #912