literal types#860
Open
Quafadas wants to merge 2 commits into
Open
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sbt prePR- doneapi-reports- doneDISCLAIMER:
I created an object called HTML Literals i what looked like the right place, then made an AI generate the code according to the design sketched out in the PR. It matches my understanding of the ask.
It's scala 3 only, because doing it also for scala 2.13 means seperating 2.13 and 2.12, which would introduce (at least for me) a headspace problem. Scala 2 & 3 are already seperate, making that leg of the task easy - I would propose to do scala 3 only to ease the maintainer burden.
If there is interest in merging, then I'll put my time behind the PR and try and help it over the line.
I did not spend a lot of time here, so I shall not feel offended, if there is little appetite, either :-). I wish to help, not burden.