Fix artifact selection when repository name casing differs#1662
Open
aaryan-iiitu wants to merge 1 commit intoscalacenter:mainfrom
Open
Fix artifact selection when repository name casing differs#1662aaryan-iiitu wants to merge 1 commit intoscalacenter:mainfrom
aaryan-iiitu wants to merge 1 commit intoscalacenter:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
While looking into issue #1576, I noticed that Scaladex can end up selecting an outdated artifact when the repository name and the artifact name differ only by casing (for example,
ScalaFXvsscalafx). This happens because artifact selection currently relies on case sensitive string comparisons and case sensitive alphabetical ordering.What this PR changes
Why this approach
The existing selection rules and priority order are kept exactly the same. This change only normalizes string comparisons so that casing differences don’t affect which artifact is selected.
Verification
coreJVM/testsuite locally; all tests pass