Skip to content

chore: bump version before release + fixes#321

Merged
cyclimse merged 19 commits intomasterfrom
chore/bump-version-before-release-and-fixes
Feb 26, 2026
Merged

chore: bump version before release + fixes#321
cyclimse merged 19 commits intomasterfrom
chore/bump-version-before-release-and-fixes

Conversation

@cyclimse
Copy link
Copy Markdown
Contributor

@cyclimse cyclimse commented Feb 24, 2026

Summary

What's changed?

  • Bump version to 0.5.0 to prepare next release
  • Implement some small fixes to ensure compatibility with both v1beta1 and v1 APIs

Why do we need this?

  • When implementing my previous MRs, I ended-up breaking the v1beta1 code path by not deploying upon creation. This is now fixed.
  • We also always redeploy on update now, to preserve the current behavior of SLS FW. The code to accomplish this is definitely on the hacky side, but this solution does not involve significant changes.

How have you tested it?

  • Tested locally ✅
    • I tested most (I would say all but maybe I missed some) features of SLS FW using both the v1beta1 and v1 and it seems to work well.

Checklist

  • I have reviewed this myself
  • There is a unit test covering every change in this PR
  • I have updated the relevant documentation

Details

@cyclimse cyclimse self-assigned this Feb 24, 2026
@cyclimse cyclimse marked this pull request as ready for review February 25, 2026 09:51
Comment thread tests/utils/misc/index.js
Comment on lines +121 to +127
console.log(
`Project ${project.name} created, waiting for it to be available...`
);

await sleep(60000);

console.log(`Project ${project.name} is now available.`);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we want to get the project instead of waiting one minute. To be honest, I don’t really know the state of the tests in this repo, so I don’t even know whether we actually use it or not, or whether this wait really slows down the tests.

Copy link
Copy Markdown
Contributor Author

@cyclimse cyclimse Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I forgot I changed it. It's a similar problem to what Leila had, when creating a project if it's not quite reconciled, when performing actions that require an IAM permission-check, you sometimes run into a permission denied that's cached for a while, failing all subsequent attempts. That's honestly what motivated to look further into the issue Leila had.

For context, the SLS FW create multiple account projects on every run, then run the tests within them.

The problem is that besides doing a sleep, there's not much we can do, because projects are not transient resources and don't expose a status. Yet, the IAM reconciliation/sync thingy is entirely async.

It genuinely seems to help, I haven't seen a permission denied in our tests since doing that, but the tests still fail randomly.

I/we need to look into it at some point, but it's a lot of effort.

@cyclimse cyclimse merged commit 1ace7db into master Feb 26, 2026
11 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants