chore: bump version before release + fixes#321
Conversation
| console.log( | ||
| `Project ${project.name} created, waiting for it to be available...` | ||
| ); | ||
|
|
||
| await sleep(60000); | ||
|
|
||
| console.log(`Project ${project.name} is now available.`); |
There was a problem hiding this comment.
question: do we want to get the project instead of waiting one minute. To be honest, I don’t really know the state of the tests in this repo, so I don’t even know whether we actually use it or not, or whether this wait really slows down the tests.
There was a problem hiding this comment.
Oh yeah, I forgot I changed it. It's a similar problem to what Leila had, when creating a project if it's not quite reconciled, when performing actions that require an IAM permission-check, you sometimes run into a permission denied that's cached for a while, failing all subsequent attempts. That's honestly what motivated to look further into the issue Leila had.
For context, the SLS FW create multiple account projects on every run, then run the tests within them.
The problem is that besides doing a sleep, there's not much we can do, because projects are not transient resources and don't expose a status. Yet, the IAM reconciliation/sync thingy is entirely async.
It genuinely seems to help, I haven't seen a permission denied in our tests since doing that, but the tests still fail randomly.
I/we need to look into it at some point, but it's a lot of effort.
This reverts commit 2823e72.
Summary
What's changed?
0.5.0to prepare next releaseWhy do we need this?
How have you tested it?
Checklist
Details