ARSN-503: Return the kms error without warning - #2432
Conversation
objectCopy and objectPutCopyPart use these functions and they both catch the error to return it to the client The KMS implementation should take care of hidding sensitive internal information
Hello bourgoismickael,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
This comment was marked as resolved.
This comment was marked as resolved.
|
/create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.1/improvement/ARSN-503-kms-err origin/development/8.1
$ git merge origin/improvement/ARSN-503-kms-err
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.1/improvement/ARSN-503-kms-errThe following options are set: create_integration_branches |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.2/improvement/ARSN-503-kms-err origin/development/8.2
$ git merge origin/w/8.1/improvement/ARSN-503-kms-err
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.2/improvement/ARSN-503-kms-errThe following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
anurag4DSB
left a comment
There was a problem hiding this comment.
I am approving the PR, your call on my comment
1be2bbb to
fed2726
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
/approve |
fed2726 to
418249b
Compare
Always return aws error code as is prefixed with KMS For some error return the same error code and message For others hide potentially sensitive message
418249b to
bf27689
Compare
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-503. Goodbye bourgoismickael. The following options are set: approve, create_integration_branches |
objectCopy and objectPutCopyPart use these functions from dataWrapper and they both catch the error to return it to the client
The KMS implementation should take care of hidding sensitive internal information
Rework error message for AWS KMS to match the output from AWS and hide some non KMS related message such as Network errors to prevent leaking sensitive information like hostnames, ip, ..