forked from awslabs/mountpoint-s3-csi-driver
-
Notifications
You must be signed in to change notification settings - Fork 1
S3CSI-204: Support CA certificates via ConfigMap #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anurag4DSB
merged 7 commits into
main
from
improvement/S3CSI-204-support-CA-certificates
Apr 1, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8c0450d
S3CSI-204: Add TLS CA certificate support in Go
anurag4DSB 2c0b663
S3CSI-204: Add TLS Helm chart configuration
anurag4DSB 5ae289d
S3CSI-204: Add TLS E2E tests and CI workflow
anurag4DSB 164fdb1
S3CSI-204: Add TLS configuration documentation
anurag4DSB f0fbf68
S3CSI-204: Add newline guard before appending custom CA
anurag4DSB 26352e4
S3CSI-204: Disable MD046 markdownlint rule globally
anurag4DSB 063ad0a
S3CSI-204: Add Helm-managed TLS CA ConfigMap creation
anurag4DSB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
charts/scality-mountpoint-s3-csi-driver/templates/tls-configmaps.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| {{- if and .Values.tls.caCertConfigMap .Values.tls.caCertData }} | ||
| # Helm-managed CA certificate ConfigMap in the controller (release) namespace. | ||
| # Created automatically when tls.caCertData is provided via --set-file. | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: {{ .Values.tls.caCertConfigMap }} | ||
| namespace: {{ .Release.Namespace }} | ||
| labels: | ||
| {{- include "scality-mountpoint-s3-csi-driver.labels" . | nindent 4 }} | ||
| data: | ||
| ca-bundle.crt: | | ||
| {{- .Values.tls.caCertData | nindent 4 }} | ||
| {{- if ne .Release.Namespace .Values.mountpointPod.namespace }} | ||
| --- | ||
| # Helm-managed CA certificate ConfigMap in the mounter pod namespace. | ||
| # Mounter pods mount this ConfigMap to inject the CA into the system trust store. | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: {{ .Values.tls.caCertConfigMap }} | ||
| namespace: {{ .Values.mountpointPod.namespace }} | ||
| labels: | ||
| {{- include "scality-mountpoint-s3-csi-driver.labels" . | nindent 4 }} | ||
| data: | ||
| ca-bundle.crt: | | ||
| {{- .Values.tls.caCertData | nindent 4 }} | ||
| {{- end }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JUnit report is written to
./test-results/e2e-tls-tests-results.xmlviaJUNIT_REPORT, but the Codecov upload step points to./tests/e2e/test-results/e2e-tls-tests-results.xml. This mismatch will cause the Codecov step to fail to find the report (or upload an empty/missing file). Align the paths (either write into./tests/e2e/test-results/or upload from./test-results/).