Skip to content

Align CRR Apply Actions step contract with the crr-configurator spec - #1246

Merged
bert-e merged 1 commit into
development/4from
feature/ARTESCA-16787-crr-apply-actions-step-contract
Jul 22, 2026
Merged

Align CRR Apply Actions step contract with the crr-configurator spec#1246
bert-e merged 1 commit into
development/4from
feature/ARTESCA-16787-crr-apply-actions-step-contract

Conversation

@hervedombya

Copy link
Copy Markdown
Contributor

Aligns the CRR wizard's Apply Actions step list with the authoritative sources: the crr-configurator NDJSON step-chain spec and the ARTESCA Cross-Region Replication procedure.

What

  • Backend-phase step IDs now match the configurator spec verbatim (create-account, create-role, attach-role-policy, create-bucket) so the NDJSON events map onto the rendered rows.
  • Restores the destination create-role step and attaches the replication policy to the role (not the user), as the ARTESCA CRR procedure requires. SetupResult.roleArn already carries this role back to the frontend.
  • The target-bucket step is explicit and its name is shown; the replication-only steps (source bucket, target bucket, replication rule) are dropped when the user opts out of creating a rule.

How

The step list is a small declarative table (when / label per step); tests cover the rendered sequence, the conditional steps, and the per-step success/failure display. Test descriptions are phrased around what the user sees.

Next

The orchestration itself (running the frontend-owned steps as real mutations alongside the backend NDJSON link, via useChainedMutations) lands in a follow-up.

@bert-e

bert-e commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@claude

claude Bot commented Jul 22, 2026

Copy link
Copy Markdown

LGTM

Review by Claude Code

@hervedombya

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/4

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1
  • development/2.2
  • development/3.0
  • development/3.1
  • development/3.2
  • development/4.0
  • development/4.1
  • development/4.2

Please check the status of the associated issue ARTESCA-16787.

Goodbye hervedombya.

The following options are set: approve

@bert-e
bert-e merged commit 017b7b7 into development/4 Jul 22, 2026
10 checks passed
@bert-e
bert-e deleted the feature/ARTESCA-16787-crr-apply-actions-step-contract branch July 22, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants