Skip to content

Keep CRR Apply Actions row statuses in sync with the running mutations - #1250

Merged
bert-e merged 1 commit into
development/4from
bugfix/ARTESCA-16787-apply-actions-status-sync
Jul 24, 2026
Merged

Keep CRR Apply Actions row statuses in sync with the running mutations#1250
bert-e merged 1 commit into
development/4from
bugfix/ARTESCA-16787-apply-actions-status-sync

Conversation

@hervedombya

Copy link
Copy Markdown
Contributor

The CRR provisioning wizard's Apply Actions table showed every row stuck on "Pending", even after the underlying operations had already succeeded or failed — so the user got no feedback and the run looked frozen.

Each row's status is derived from the mutation instances handed to useChainedMutations, but the config holding them was memoized without depending on those instances. React Query returns a new result object on every status change, so the memo kept the original idle instances and the rows never moved off "Pending".

Depending on the mutation instances in that memo — the approach the ISV Apply Actions step already uses — rebuilds the config whenever a status changes, so rows now reflect live Success / Failed / Retry. The chain is not restarted: useChainedMutations keys its reset on the step ids, not the array identity.

Verified against a live ARTESCA platform: the rows now update in real time through the run.

@bert-e

bert-e commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@claude

claude Bot commented Jul 24, 2026

Copy link
Copy Markdown

LGTM

Review by Claude Code

@hervedombya
hervedombya force-pushed the bugfix/ARTESCA-16787-apply-actions-status-sync branch from 3306a9a to b51c1ec Compare July 24, 2026 11:54
@claude

claude Bot commented Jul 24, 2026

Copy link
Copy Markdown

LGTM

Review by Claude Code

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.76%. Comparing base (a965620) to head (b51c1ec).
⚠️ Report is 5 commits behind head on development/4.

Additional details and impacted files
@@                Coverage Diff                @@
##           development/4    #1250      +/-   ##
=================================================
- Coverage          63.79%   63.76%   -0.03%     
=================================================
  Files                256      256              
  Lines               9454     9459       +5     
  Branches            2559     2561       +2     
=================================================
+ Hits                6031     6032       +1     
- Misses              3412     3416       +4     
  Partials              11       11              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ZiyangLinScality ZiyangLinScality left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hervedombya

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/4

The following branches will NOT be impacted:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1
  • development/2.2
  • development/3.0
  • development/3.1
  • development/3.2
  • development/4.0
  • development/4.1
  • development/4.2

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e

bert-e commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/4

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1
  • development/2.2
  • development/3.0
  • development/3.1
  • development/3.2
  • development/4.0
  • development/4.1
  • development/4.2

Please check the status of the associated issue ARTESCA-16787.

Goodbye hervedombya.

@bert-e
bert-e merged commit 52ef1a3 into development/4 Jul 24, 2026
12 checks passed
@bert-e
bert-e deleted the bugfix/ARTESCA-16787-apply-actions-status-sync branch July 24, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants