Skip to content

feature(crr): build the CRR wizard Summary step - #1266

Merged
bert-e merged 1 commit into
development/4from
feature/crr-summary-polish
Jul 28, 2026
Merged

feature(crr): build the CRR wizard Summary step#1266
bert-e merged 1 commit into
development/4from
feature/crr-summary-polish

Conversation

@hervedombya

@hervedombya hervedombya commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

TL;DR

Adds the final Summary step to the CRR provisioning wizard — a recap of the created location, replication rule and buckets, with a Finish action that drops the user on the right page.

Context

Last user-facing step of the CRR setup wizard, after Configure and Apply Actions. It also settles the naming of the two artefacts the wizard creates on a single key scheme — location-<account>-<host> for the location and replication-<account> for the replication rule — shared between the mutations that create them and this recap, so the two can never drift.

Screenshot

CRR wizard Summary step

Review focus

  • 🟡 steps/ApplyActionsStep/crrLocation.tsbuildCRRLocationName / buildCRRReplicationRuleId — the new identifier scheme. The create-location and create-replication-rule mutations and the Summary all read names from these two helpers, so what gets created and what gets shown stay in lockstep.
  • steps/SummaryStep.tsxonFinish — routes to the new source bucket when a replication rule was created, and to the buckets list otherwise.

How to test

  1. Data Management → create a CRR configuration, complete Configure and Apply Actions with a replication rule.
  2. On Summary, confirm it lists the location (location-<dest-account>-<host>), the rule (replication-<dest-account>), and the source & target buckets.
  3. Click Finish → you land on the new source bucket page.
  4. Re-run without a replication rule → only the location is shown, and Finish lands on the buckets list.

@bert-e

bert-e commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

Comment thread src/react/locations/CRRSetupWizard/steps/SummaryStep.tsx Outdated
@claude

claude Bot commented Jul 28, 2026

Copy link
Copy Markdown
  • accountName is not guarded in the Finish navigation path (SummaryStep.tsx:21). Since props are Partial<ConfigureFormValues>, accountName can be undefined while createReplicationRule and sourceBucketName are truthy, producing /accounts/undefined/buckets/.... Add accountName to the guard.

    Review by Claude Code

Comment thread src/react/locations/CRRSetupWizard/steps/SummaryStep.tsx Outdated
@claude

claude Bot commented Jul 28, 2026

Copy link
Copy Markdown
  • SummaryStep.tsx:21accountName can be undefined (all props are Partial) but is not included in the navigation guard, producing a /accounts/undefined/buckets/... URL.
    • Add && accountName to the ternary condition.

Review by Claude Code

@hervedombya
hervedombya force-pushed the feature/crr-summary-polish branch from 2da6343 to 8a81c73 Compare July 28, 2026 14:16
@claude

claude Bot commented Jul 28, 2026

Copy link
Copy Markdown

LGTM

Review by Claude Code

1 similar comment
@claude

claude Bot commented Jul 28, 2026

Copy link
Copy Markdown

LGTM

Review by Claude Code

@ZiyangLinScality ZiyangLinScality left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hervedombya

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/4

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1
  • development/2.2
  • development/3.0
  • development/3.1
  • development/3.2
  • development/4.0
  • development/4.1
  • development/4.2

Please check the status of the associated issue None.

Goodbye hervedombya.

The following options are set: approve

@bert-e
bert-e merged commit 8a81c73 into development/4 Jul 28, 2026
10 checks passed
@bert-e
bert-e deleted the feature/crr-summary-polish branch July 28, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants