feature(crr): build the CRR wizard Summary step - #1266
Merged
Conversation
Contributor
Hello hervedombya,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
|
Review by Claude Code |
hervedombya
force-pushed
the
feature/crr-summary-polish
branch
from
July 28, 2026 14:16
2da6343 to
8a81c73
Compare
|
LGTM |
1 similar comment
|
LGTM |
Contributor
Author
|
/approve |
Contributor
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye hervedombya. The following options are set: approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds the final Summary step to the CRR provisioning wizard — a recap of the created location, replication rule and buckets, with a Finish action that drops the user on the right page.
Context
Last user-facing step of the CRR setup wizard, after Configure and Apply Actions. It also settles the naming of the two artefacts the wizard creates on a single key scheme —
location-<account>-<host>for the location andreplication-<account>for the replication rule — shared between the mutations that create them and this recap, so the two can never drift.Screenshot
Review focus
steps/ApplyActionsStep/crrLocation.ts›buildCRRLocationName/buildCRRReplicationRuleId— the new identifier scheme. The create-location and create-replication-rule mutations and the Summary all read names from these two helpers, so what gets created and what gets shown stay in lockstep.steps/SummaryStep.tsx›onFinish— routes to the new source bucket when a replication rule was created, and to the buckets list otherwise.How to test
location-<dest-account>-<host>), the rule (replication-<dest-account>), and the source & target buckets.