Skip to content

improvement(crr): rework Configure connection feedback and destination error copy - #1268

Merged
bert-e merged 1 commit into
development/4from
improvement/crr-configure-toasts-and-connection-feedback
Jul 29, 2026
Merged

improvement(crr): rework Configure connection feedback and destination error copy#1268
bert-e merged 1 commit into
development/4from
improvement/crr-configure-toasts-and-connection-feedback

Conversation

@hervedombya

@hervedombya hervedombya commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

TL;DR

Reworks the connection feedback on the CRR wizard's Configure step: professional error copy aligned with the product's conventions, a persistent inline Connected indicator, and a disabled Check Connection button with a why-tooltip in place of a post-click error toast.

Context

The Configure step's toasts were ad-hoc diagnostic strings (The destination cluster did not respond.) that didn't match the product's copy conventions, and connection feedback was toast-only — nothing persisted to tell the user the destination was verified before they moved on.

Approach

  • Error copy follows the two house patterns: validation problems read as a state (The destination certificate is invalid.), operation failures read as Failed to <action>. <remediation>. (e.g. Failed to authenticate with the destination. Check your credentials.).
  • Persistent state vs. transient ack: a successful check still fires a Connection established toast, but the source of truth is now an inline indicator that reflects the current verified state — it clears the moment a connection field is edited.
  • No more "fill the fields" error toast: Check Connection is disabled until the connection fields are valid, with a tooltip explaining why (core-ui's disabled-button-carries-a-why-tooltip pattern).

Screenshots

Connected indicator after a successful check:

Connected indicator on the Configure step

Check Connection disabled, with the why-tooltip:

Check Connection disabled with tooltip

Review focus

  • 🟡 steps/ConfigureStep/ConfigureStep.tsxerrorCopy / onCheckConnection — the reworded copy and the removal of the fields-incomplete toast (now handled by the disabled button).
  • steps/ConfigureStep/DestinationConnectionSection.tsxconnectionValid / Connected indicator — button gating + the inline state derived from the last successful verify.

How to test

  1. Data Management → create a CRR configuration.
  2. With empty/invalid connection fields, hover Check Connection → it is disabled with the tooltip "Fill in the destination fields to check the connection".
  3. Fill valid destination fields → the button enables; on a successful check a Connection established toast shows and a 🟢 Connected: <instance> indicator appears below the section.
  4. Edit any connection field → the indicator clears (state is no longer verified).
  5. Trigger failures (invalid certificate, unreachable URL, wrong credentials) → the error toasts follow the new copy.

@bert-e

bert-e commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@claude

claude Bot commented Jul 28, 2026

Copy link
Copy Markdown

LGTM

Review by Claude Code

@hervedombya
hervedombya force-pushed the improvement/crr-configure-toasts-and-connection-feedback branch from 7259e41 to 9e4ece9 Compare July 29, 2026 08:23
@claude

claude Bot commented Jul 29, 2026

Copy link
Copy Markdown

LGTM

Review by Claude Code

@hervedombya

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/4

The following branches have NOT changed:

  • development/1.4
  • development/1.5
  • development/1.6
  • development/2.0
  • development/2.1
  • development/2.2
  • development/3.0
  • development/3.1
  • development/3.2
  • development/4.0
  • development/4.1
  • development/4.2

Please check the status of the associated issue None.

Goodbye hervedombya.

The following options are set: approve

@bert-e
bert-e merged commit 9e4ece9 into development/4 Jul 29, 2026
10 checks passed
@bert-e
bert-e deleted the improvement/crr-configure-toasts-and-connection-feedback branch July 29, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants