improvement(crr): rework Configure connection feedback and destination error copy - #1268
Merged
bert-e merged 1 commit intoJul 29, 2026
Conversation
Contributor
Hello hervedombya,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
|
LGTM |
hervedombya
force-pushed
the
improvement/crr-configure-toasts-and-connection-feedback
branch
from
July 29, 2026 08:23
7259e41 to
9e4ece9
Compare
|
LGTM |
ZiyangLinScality
approved these changes
Jul 29, 2026
Contributor
Author
|
/approve |
Contributor
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye hervedombya. The following options are set: approve |
bert-e
deleted the
improvement/crr-configure-toasts-and-connection-feedback
branch
July 29, 2026 08:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Reworks the connection feedback on the CRR wizard's Configure step: professional error copy aligned with the product's conventions, a persistent inline Connected indicator, and a disabled Check Connection button with a why-tooltip in place of a post-click error toast.
Context
The Configure step's toasts were ad-hoc diagnostic strings (
The destination cluster did not respond.) that didn't match the product's copy conventions, and connection feedback was toast-only — nothing persisted to tell the user the destination was verified before they moved on.Approach
The destination certificate is invalid.), operation failures read asFailed to <action>. <remediation>.(e.g.Failed to authenticate with the destination. Check your credentials.).Connection establishedtoast, but the source of truth is now an inline indicator that reflects the current verified state — it clears the moment a connection field is edited.Screenshots
Connected indicator after a successful check:
Check Connection disabled, with the why-tooltip:
Review focus
steps/ConfigureStep/ConfigureStep.tsx›errorCopy/onCheckConnection— the reworded copy and the removal of the fields-incomplete toast (now handled by the disabled button).steps/ConfigureStep/DestinationConnectionSection.tsx›connectionValid/ Connected indicator — button gating + the inline state derived from the last successful verify.How to test