fix: do not render progress bar on AddDetail when visibility is false (fixes #236) - #237
Open
tonycoder-hub wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #236
When a progress bar is created with
OptionSetVisibility(false), callingAddDetail(detail)immediately callsp.render(). Becauserender()previously lacked a check forp.config.invisible, it bypassed the visibility setting and rendered ANSI progress bar escape codes and output to the configured writer.Changes
if p.config.invisible { return nil }at the start ofrender(). This ensures that all render paths respect the invisible setting.TestInvisibleWithAddDetailinprogressbar_test.goverifying that no bytes are output whenAddDetailis invoked on an invisible progress bar.