Adding Principal Covariates Classification (PCovC) Code#248
Merged
Conversation
New PR for exclusively adding PCovC code
e302dbd to
c0a16aa
Compare
3995e16 to
df8fa2e
Compare
rosecers
reviewed
May 16, 2025
Collaborator
rosecers
left a comment
There was a problem hiding this comment.
Overall this is looking very good. There's some standardizing tasks I noted and a couple style/organization questions I'd like discussed before approving.
Collaborator
PicoCentauri
left a comment
There was a problem hiding this comment.
Thanks for this nice new feature!
I took a very quick look. Once the example is a clean Python file I can check more carefully.
Collaborator
PicoCentauri
left a comment
There was a problem hiding this comment.
Without checking the math carefully the overall design looks good.
Can you update the CHANGELOG file in the root of the repo with the addition you made. Thanks
ddee0d5 to
12a2c39
Compare
PicoCentauri
approved these changes
May 28, 2025
Collaborator
PicoCentauri
left a comment
There was a problem hiding this comment.
Thanks LGTM. If @rosecers is also happy we can merge.
Collaborator
|
Should we also change the PCovR section of the landing page to something hybrid learning-esque? |
Collaborator
Author
cajchristian
approved these changes
May 29, 2025
rosecers
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adding PCovC code, examples, and testing suite. Adding a PCov base class that both PCovR and PCovC inherit from.
Contributor (creator of PR) checklist
For Reviewer
📚 Documentation preview 📚: https://scikit-matter--248.org.readthedocs.build/en/248/