Open
Conversation
added 5 commits
July 21, 2019 18:46
…bfqfft into no-exceptional-control-flow
Author
|
I feel there may be a cleaner way of doing this, I am open to suggestions. |
AntoineRondelet
added a commit
to clearmatics/libfqfft
that referenced
this pull request
Oct 13, 2021
Exceptions fix - merge scipr-lab/libfqfft#12 (depends on #6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the usage of
try ... catchfor control flow in theget_evaluation_domainfunction.This fixes the problems described by:
When exception control flow is disabled at the compiler-level, either by choice (to generally speed things up) or by requirement (e.g. the Cheerp WASM compiler doesn't support catching exceptions), then the code either
abort()or picks the wrong option. This was also triggering misbehaviour with optimised builds on OSX with Clang (where the wrong option is picked, due to buggy catch handling).This commit also comments-out the comment in the inline-assembly in
basic_radix2_domain_aux.tcc, which was breaking Emscripten WASM builds due to it lacking support for inline assembly (of any kind).There is a different patch in MinaProtocol/mina#1419 but it breaks compatibility with the API, this patch remains API compatibility.
I added the
get_root_of_unity_will_throwfunction, to determine if getting the root of unity will throw, however I need to avoid duplicating the code at:I will make these changes to be included in the pull request.