Skip to content

Update container-common-scripts - #338

Merged
phracek merged 3 commits into
sclorg:masterfrom
phracek:update_ccs
Aug 10, 2026
Merged

Update container-common-scripts#338
phracek merged 3 commits into
sclorg:masterfrom
phracek:update_ccs

Conversation

@phracek

@phracek phracek commented Aug 10, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Only updates container-common-scripts

Summary by CodeRabbit

  • Documentation
    • Added a link to Red Hat Enterprise Linux Application Streams lifecycle information for the MariaDB stream.
    • Clarified upgrade guidance with improved punctuation.
  • Bug Fixes
    • Improved replication discovery reliability by retrying transient command results and extending the retry limit.
  • Chores
    • Updated shared project content to the latest revision.

phracek added 2 commits August 10, 2026 09:46
@phracek
Update ContainerCommonScripts
e1cb125 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Update README.md for dist-gen generated sources
9e4fb85 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek

phracek commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

[test][test-pytest]

@phracek phracek mentioned this pull request Aug 10, 2026
Closed
@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The change extends replication discovery retries, handles boolean SQL results during discovery, updates MariaDB lifecycle documentation, corrects warning punctuation, and advances the common submodule reference.

Changes

Replication discovery

Layer / File(s) Summary
Replication retry handling
test/test_container_replication.py		 Replication discovery now makes up to 10 attempts. Boolean SQL-command results cause a 3-second wait before retrying.

MariaDB documentation

Layer / File(s) Summary
MariaDB guidance updates
src/root/usr/share/container-scripts/mysql/README.md, 11.8/root/usr/share/container-scripts/mysql/README.md		 The documentation adds a Red Hat Enterprise Linux Application Streams lifecycle link and changes warning punctuation from a semicolon to a period.
Common submodule pointer
common		 The common submodule reference advances to commit 300f499e1f4f0fdc5d9b4b470977cc39000810f3.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary dependency update and matches the main change in the pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Pull Request validation

Failed

🔴 Failed or pending statuses:

  • CodeRabbit[pending]

🔴 Review - Missing review from a member (1 required)

Triggered by Workflow Run

@github-actions

github-actions Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
CentOS Stream 9 - 10.11CentOS-Stream-9x86_64✅ passed10.08.2026 10:42:3513min 59stest pipeline
RHEL8 - 10.3RHEL-8.10.0-Nightlyx86_64✅ passed10.08.2026 10:28:1016min 28stest pipeline
CentOS Stream 9 - PyTest - 10.11CentOS-Stream-9x86_64✅ passed10.08.2026 10:48:2820min 19stest pipeline
CentOS Stream 10 - 11.8CentOS-Stream-10x86_64✅ passed10.08.2026 10:28:0811min 49stest pipeline
RHEL8 - PyTest - 10.11RHEL-8.10.0-Nightlyx86_64✅ passed10.08.2026 10:28:1017min 23stest pipeline
RHEL9 - Unsubscribed host - PyTest - 10.11RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 10:28:1021min 54stest pipeline
RHEL9 - Unsubscribed host - 10.11RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 07:49:5521min 35stest pipeline
RHEL9 - Unsubscribed host - PyTest - 10.5RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 10:42:4821min 36stest pipeline
RHEL8 - 10.5RHEL-8.10.0-Nightlyx86_64✅ passed10.08.2026 10:40:3415min 13stest pipeline
RHEL9 - PyTest - 10.11RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 10:28:1124min 5stest pipeline
RHEL9 - PyTest - 10.5RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 10:48:3131min 49stest pipeline
Fedora - 11.8Fedora-latestx86_64✅ passed10.08.2026 10:28:119min 35stest pipeline
RHEL8 - PyTest - 10.5RHEL-8.10.0-Nightlyx86_64✅ passed10.08.2026 10:42:3929min 32stest pipeline
Fedora - 10.11Fedora-latestx86_64✅ passed10.08.2026 10:52:3617min 7stest pipeline
CentOS Stream 10 - 10.11CentOS-Stream-10x86_64✅ passed10.08.2026 10:28:1911min 37stest pipeline
CentOS Stream 9 - PyTest - 10.5CentOS-Stream-9x86_64✅ passed10.08.2026 10:46:3520min 23stest pipeline
Fedora - PyTest - 10.11Fedora-latestx86_64✅ passed10.08.2026 10:28:0913min 58stest pipeline
RHEL9 - PyTest - 11.8RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 10:40:4528min 5stest pipeline
RHEL9 - 11.8RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 10:46:4331min 43stest pipeline
RHEL10 - PyTest - 10.11RHEL-10.2-Nightlyx86_64✅ passed10.08.2026 10:28:0922min 5stest pipeline
RHEL9 - 10.5RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 10:28:0923min 25stest pipeline
CentOS Stream 9 - PyTest - 11.8CentOS-Stream-9x86_64✅ passed10.08.2026 10:50:3623min 50stest pipeline
RHEL8 - 10.11RHEL-8.10.0-Nightlyx86_64✅ passed10.08.2026 10:28:1715min 12stest pipeline
RHEL10 - Unsubscribed host - PyTest - 10.11RHEL-10.2-Nightlyx86_64✅ passed10.08.2026 10:42:3325min 6stest pipeline
RHEL10 - Unsubscribed host - 11.8RHEL-10.2-Nightlyx86_64✅ passed10.08.2026 10:28:1118min 38stest pipeline
RHEL9 - 10.11RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 10:52:3322min 47stest pipeline
CentOS Stream 10 - PyTest - 11.8CentOS-Stream-10x86_64✅ passed10.08.2026 10:28:1013min 42stest pipeline
RHEL9 - Unsubscribed host - 10.5RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 10:54:5131min 32stest pipeline
CentOS Stream 10 - PyTest - 10.11CentOS-Stream-10x86_64✅ passed10.08.2026 10:28:1113min 54stest pipeline
RHEL10 - 10.11RHEL-10.2-Nightlyx86_64✅ passed10.08.2026 10:28:0919min 43stest pipeline
RHEL9 - Unsubscribed host - 11.8RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 08:15:3822min 27stest pipeline
RHEL9 - Unsubscribed host - PyTest - 11.8RHEL-9.8.0-Nightlyx86_64✅ passed10.08.2026 10:42:2826min 19stest pipeline
RHEL10 - 11.8RHEL-10.2-Nightlyx86_64✅ passed10.08.2026 10:28:1018min 46stest pipeline
CentOS Stream 9 - 11.8CentOS-Stream-9x86_64✅ passed10.08.2026 10:28:1112min 39stest pipeline
Fedora - PyTest - 11.8Fedora-latestx86_64✅ passed10.08.2026 10:28:1712min 19stest pipeline
RHEL10 - Unsubscribed host - 10.11RHEL-10.2-Nightlyx86_64✅ passed10.08.2026 10:38:3023min 1stest pipeline
RHEL10 - PyTest - 11.8RHEL-10.2-Nightlyx86_64✅ passed10.08.2026 10:48:3831min 30stest pipeline
RHEL10 - Unsubscribed host - PyTest - 11.8RHEL-10.2-Nightlyx86_64✅ passed10.08.2026 10:52:3723min 32stest pipeline
RHEL8 - PyTest - 10.3RHEL-8.10.0-Nightlyx86_64✅ passed10.08.2026 10:44:4029min 21stest pipeline
CentOS Stream 9 - 10.5CentOS-Stream-9x86_64✅ passed10.08.2026 10:48:3717min 10stest pipeline

@phracek
Increase time for starting SLAVE
2493d80 
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek

phracek commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

[test][test-pytest]

@phracek
phracek merged commit 66d14fa into sclorg:master Aug 10, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr/failing-ci pr/missing-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@phracek