Implemented parsing Roman Numerals#63
Open
AmPhIbIaN26 wants to merge 11 commits intoscrapinghub:masterfrom
Open
Implemented parsing Roman Numerals#63AmPhIbIaN26 wants to merge 11 commits intoscrapinghub:masterfrom
AmPhIbIaN26 wants to merge 11 commits intoscrapinghub:masterfrom
Conversation
I have implemented parsing for roman, for the case of parsing any roman numeral in a sentence you have to specify the language.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This reverts commit 386fdd9.
I have implemented parsing for roman, for the case of parsing any roman numeral in a sentence you have to specify the language.
This reverts commit 6658bc4.
This reverts commit 81ed627.
This reverts commit 386fdd9.
added encoding='utf8' to __init__.py
This reverts commit b36483e.
This reverts commit ce81365.
This reverts commit c6285cb.
This reverts commit ff64b93.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the
parse_number()now works like this:And
parse()works like this: